Changeset 51916 for trunk/src/wp-includes/cron.php

Timestamp:

10/18/2021 12:51:00 PM (5 years ago)

Author:

hellofromTonya

Message:

Cron: Fix malformed cron array in wp_schedule_single_event() when _get_cron_array() returns false.

In wp_schedule_single_event(), the cron info array is retrieved via a call to _get_cron_array() and straight away cast to an array. But as the documentation for that function (correctly) states, the return type of that function is array|false, where false is returned for a site where no cron jobs have been scheduled (yet).

In the case that _get_cron_array() would return false, this would now unintentionally create an array with a single entry with key 0 and as the value false.

This is a bug. Fixed now by adding validation to the output of _get_cron_array() and initializing $crons to an empty array if false was returned.

Tests added first to prove the bug (a) was introduced in #44818 [44917] and (b) is now fixed.

Follow-up to [44917].

Props jrf, peterwilsoncc.
Fixes #53950.

File:

• trunk/src/wp-includes/cron.php (modified) (1 diff)

trunk/src/wp-includes/cron.php

@@ -119 +119 @@
          * are considered duplicates.
          */
-        $crons     = (array) _get_cron_array();
+        $crons = _get_cron_array();
+        if ( ! is_array( $crons ) ) {
+                $crons = array();
+        }
+
         $key       = md5( serialize( $event->args ) );
         $duplicate = false;