Changeset 51934

Timestamp:

10/25/2021 07:28:04 PM (3 years ago)

Author:

desrosj

Message:

Build/Test Tools: Restore Slack notifications for older branches.

In [51921], the GitHub Actions workflows were updated to utilize the Slack notifications workflow as a callable one instead of on the workflow_run event.

This eliminated the need for an additional “Slack Notifications” workflow run for every completed workflow, but only when other workflows are updated as well. This resulted in notifications from older branches breaking, as the changes in [51921] were not backported.

Instead of backporting the needed changes now (the Slack workflow is still being polished), this commit partially restores the workflow_run event for older branches so that notifications will resume.

See #53363.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (12 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -7 +7 @@
 
 on:
+  workflow_run:
+    workflows:
+      - Code Coverage Report
+      - Coding Standards
+      - End-to-end Tests
+      - JavaScript Tests
+      - PHP Compatibility
+      - PHPUnit Tests
+      - Test NPM
+      - Test old branches
+    types:
+      - completed
+    branches:
+      - '[3-4].[0-9]'
+      - '5.[0-8]'
+
   workflow_call:
     secrets:
@@ -22 +38 @@
         required: true
 
+env:
+  CURRENT_BRANCH: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_branch || github.ref_name }}
+
 jobs:
   # Gathers the details needed for Slack notifications.
@@ -29 +48 @@
   #
   # Performs the following steps:
+  # - Retrieves the workflow ID (if necessary).
+  # - Retrieves the workflow URL (if necessary).
   # - Retrieves the previous workflow run and stores its conclusion.
   # - Sets the previous conclusion as an output.
+  # - Prepares the commit message.
   # - Constructs and stores a message payload as an output.
   prepare:
@@ -43 +65 @@
       - name: Get the workflow ID
         id: current-workflow-id
+        if: ${{ github.event_name == 'push' }}
         uses: actions/github-script@441359b1a30438de65712c2fbca0abe4816fa667 # v5.0.0
         with:
@@ -56 +79 @@
         id: current-workflow-url
         uses: actions/github-script@441359b1a30438de65712c2fbca0abe4816fa667 # v5.0.0
+        if: ${{ github.event_name == 'push' }}
         with:
           script: |
@@ -73 +97 @@
               owner: '${{ github.repository_owner }}',
               repo: 'wordpress-develop',
-              workflow_id: ${{ steps.current-workflow-id.outputs.result }},
-              branch: '${{ github.ref_name }}',
+              workflow_id: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.workflow_id || steps.current-workflow-id.outputs.result }},
+              branch: '${{ env.CURRENT_BRANCH }}',
               per_page: 1,
               page: 2,
@@ -88 +112 @@
         run: |
           COMMIT_MESSAGE=$(cat <<'EOF' | awk 'NR==1' | sed 's/`/\\`/g' | sed 's/\"/\\\\"/g'
-          ${{ github.event.head_commit.message }}
+          ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_commit.message || github.event.head_commit.message }}
           EOF
           )
@@ -95 +119 @@
       - name: Construct payload and store as an output
         id: create-payload
-        run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.workflow }}\",\"ref_name\":\"${{ github.ref_name }}\",\"run_url\":\"${{ steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
+        run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.workflow }}\",\"ref_name\":\"${{ env.CURRENT_BRANCH }}\",\"run_url\":\"${{ github.event_name == 'workflow_run' && github.event.workflow_run.html_url || steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
 
   # Posts notifications when a workflow fails.
@@ -102 +126 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ failure() }}
+    if: ${{ github.event_name == 'push' && failure() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure' }}
 
     steps:
@@ -117 +141 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && success() }}
+    if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && ( github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' ) }}
 
     steps:
@@ -132 +156 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ success() }}
+    if: ${{ github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' }}
 
     steps:
@@ -147 +171 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ cancelled() }}
+    if: ${{ github.event_name == 'push' && cancelled() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'cancelled' }}
 
     steps: