Changeset 51937

Timestamp:

10/25/2021 08:26:45 PM (3 years ago)

Author:

desrosj

Message:

Build/Test Tools: Use the correct workflow name in notifications on workflow_run.

When a workflow is triggered through a workflow_run event, the context is not the original workflow. The details about the original workflow are passed through the github.event context.

This also moves the conditional check controlling whether the Slack workflow is run into the calling workflows to prevent them from running for pull requests.

Follow up to [51921-51922,51924-51925,51934].

See #53363.

Location:

trunk/.github/workflows

Files:

• coding-standards.yml (modified) (1 diff)
• end-to-end-tests.yml (modified) (1 diff)
• javascript-tests.yml (modified) (1 diff)
• php-compatibility.yml (modified) (1 diff)
• phpunit-tests.yml (modified) (1 diff)
• slack-notifications.yml (modified) (1 diff)
• test-coverage.yml (modified) (1 diff)
• test-npm.yml (modified) (1 diff)
• test-old-branches.yml (modified) (1 diff)

trunk/.github/workflows/coding-standards.yml

@@ -152 +152 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ phpcs, jshint ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/end-to-end-tests.yml

@@ -122 +122 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ e2e-tests ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/javascript-tests.yml

@@ -91 +91 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ test-js ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/php-compatibility.yml

@@ -93 +93 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ php-compatibility ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/phpunit-tests.yml

@@ -248 +248 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ test-php ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/slack-notifications.yml

@@ -119 +119 @@
       - name: Construct payload and store as an output
         id: create-payload
-        run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.workflow }}\",\"ref_name\":\"${{ env.CURRENT_BRANCH }}\",\"run_url\":\"${{ github.event_name == 'workflow_run' && github.event.workflow_run.html_url || steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
+        run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.event_name == 'workflow_run' && github.event.workflow_run.name || github.workflow }}\",\"ref_name\":\"${{ env.CURRENT_BRANCH }}\",\"run_url\":\"${{ github.event_name == 'workflow_run' && github.event.workflow_run.html_url || steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
 
   # Posts notifications when a workflow fails.

trunk/.github/workflows/test-coverage.yml

@@ -174 +174 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ test-coverage-report ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/test-npm.yml

@@ -160 +160 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ test-npm, test-npm-macos ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}

trunk/.github/workflows/test-old-branches.yml

@@ -75 +75 @@
     uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@master
     needs: [ dispatch-workflows-for-old-branches ]
-    if: ${{ always() }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}