Changeset 51962 for trunk/tests/phpunit/tests/rest-api.php

Timestamp:

10/31/2021 11:15:10 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Support custom namespaces for custom post types.

While a custom post type can define a custom route by using the rest_base argument, a namespace of wp/v2 was assumed. This commit introduces support for a rest_namespace argument.

A new rest_get_route_for_post_type_items function has been introduced and the rest_get_route_for_post function updated to facilitate getting the correct route for custom post types.

While the WordPress Core Block Editor bootstrap code has been updated to use these API functions, for maximum compatibility sticking with the default wp/v2 namespace is recommended until the API functions see wider use.

Props spacedmonkey, swissspidy.
Fixes #53656.

File:

• trunk/tests/phpunit/tests/rest-api.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api.php

@@ -1831 +1831 @@
 
     /**
+     * @ticket 53656
+     */
+    public function test_rest_get_route_for_post_custom_namespace() {
+        register_post_type(
+            'cpt',
+            array(
+                'show_in_rest'   => true,
+                'rest_base'      => 'cpt',
+                'rest_namespace' => 'wordpress/v1',
+            )
+        );
+        $post = self::factory()->post->create_and_get( array( 'post_type' => 'cpt' ) );
+
+        $this->assertSame( '/wordpress/v1/cpt/' . $post->ID, rest_get_route_for_post( $post ) );
+        unregister_post_type( 'cpt' );
+    }
+
+    /**
+     * @ticket 53656
+     */
+    public function test_rest_get_route_for_post_type_items() {
+        $this->assertSame( '/wp/v2/posts', rest_get_route_for_post_type_items( 'post' ) );
+    }
+
+    /**
+     * @ticket 53656
+     */
+    public function test_rest_get_route_for_post_type_items_custom_namespace() {
+        register_post_type(
+            'cpt',
+            array(
+                'show_in_rest'   => true,
+                'rest_base'      => 'cpt',
+                'rest_namespace' => 'wordpress/v1',
+            )
+        );
+
+        $this->assertSame( '/wordpress/v1/cpt', rest_get_route_for_post_type_items( 'cpt' ) );
+        unregister_post_type( 'cpt' );
+    }
+
+    /**
      * @ticket 49116
      */
@@ -1840 +1882 @@
     /**
      * @ticket 49116
+     * @ticket 53656
      */
     public function test_rest_get_route_for_post_custom_controller() {
         $post = self::factory()->post->create_and_get( array( 'post_type' => 'wp_block' ) );
-        $this->assertSame( '', rest_get_route_for_post( $post ) );
+        $this->assertSame( '/wp/v2/blocks/' . $post->ID, rest_get_route_for_post( $post ) );
     }