Changeset 51967 for trunk/src/wp-content/themes/twentytwenty/template-parts/modal-menu.php

Timestamp:

11/01/2021 09:45:45 PM (3 years ago)

Author:

joedolson

Message:

General: Remove role="navigation" from nav elements.

Role="navigation" was required for assistive technology to recognize HTML5 element's native ARIA roles while HTML5 and ARIA were being introduced. With the deprecation of IE11, the role attribute is only required when mapping elements that don't have native role.

Props costdev, mukesh27.
Fixes #54054.

File:

• trunk/src/wp-content/themes/twentytwenty/template-parts/modal-menu.php (modified) (3 diffs)

trunk/src/wp-content/themes/twentytwenty/template-parts/modal-menu.php

@@ -46 +46 @@
                     ?>
 
-                    <nav class="expanded-menu<?php echo esc_attr( $expanded_nav_classes ); ?>" aria-label="<?php echo esc_attr_x( 'Expanded', 'menu', 'twentytwenty' ); ?>" role="navigation">
+                    <nav class="expanded-menu<?php echo esc_attr( $expanded_nav_classes ); ?>" aria-label="<?php echo esc_attr_x( 'Expanded', 'menu', 'twentytwenty' ); ?>">
 
                         <ul class="modal-menu reset-list-style">
@@ -71 +71 @@
                     ?>
 
-                    <nav class="mobile-menu" aria-label="<?php echo esc_attr_x( 'Mobile', 'menu', 'twentytwenty' ); ?>" role="navigation">
+                    <nav class="mobile-menu" aria-label="<?php echo esc_attr_x( 'Mobile', 'menu', 'twentytwenty' ); ?>">
 
                         <ul class="modal-menu reset-list-style">
@@ -115 +115 @@
                 <?php if ( has_nav_menu( 'social' ) ) { ?>
 
-                    <nav aria-label="<?php esc_attr_e( 'Expanded Social links', 'twentytwenty' ); ?>" role="navigation">
+                    <nav aria-label="<?php esc_attr_e( 'Expanded Social links', 'twentytwenty' ); ?>">
                         <ul class="social-menu reset-list-style social-icons fill-children-current-color">