Changeset 51968 for trunk/tests/phpunit/tests/formatting/wpRelUgc.php

Timestamp:

11/01/2021 10:22:49 PM (3 years ago)

Author:

hellofromTonya

Message:

Build/Test Tools: Ignore "null to nullable" deprecations for select tests.

Adds an expectation for PHP 8.1 "passing null to non-nullable" deprecation notice to select tests where the deprecation is generated by one of the functions in the wp-includes/formatting.php file, either via a filter hook callback or by a direct call.

Instead of haphazardly fixing these issues exposed by the tests, a more structural and all-encompassing solution for input validation should be architected and implemented as otherwise, we'll keep running into similar issues time and again with each new PHP version.

To discourage people from "fixing" these issues now anyway, this commit "hides" nearly all of these issues from the test runs.

Once a more structural solution is designed, these tests and the underlying functions causing the deprecation notices should be revisited and the structural solution put in place.

Includes a few minor other tweaks to select tests:

• Removing a stray return (twice) from assertion statements.
• Removing calls to ob_*() functions in favour of letting PHPUnit manage the output catching. This prevents warnings along the lines of Test code or tested code did not (only) close its own output buffers.

Props jrf, hellofromTonya.
See #53635.

File:

• trunk/tests/phpunit/tests/formatting/wpRelUgc.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/wpRelUgc.php

@@ -10 +10 @@
      */
     public function test_add_ugc() {
+        if ( PHP_VERSION_ID >= 80100 ) {
+            /*
+             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
+             * via hooked in filter functions until a more structural solution to the
+             * "missing input validation" conundrum has been architected and implemented.
+             */
+            $this->expectDeprecation();
+            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
+        }
+
         $content  = '<p>This is some cool <a href="/">Code</a></p>';
         $expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow ugc\">Code</a></p>';
@@ -19 +29 @@
      */
     public function test_convert_ugc() {
+        if ( PHP_VERSION_ID >= 80100 ) {
+            /*
+             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
+             * via hooked in filter functions until a more structural solution to the
+             * "missing input validation" conundrum has been architected and implemented.
+             */
+            $this->expectDeprecation();
+            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
+        }
+
         $content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
         $expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow ugc\">Code</a></p>';
@@ -28 +48 @@
      * @dataProvider data_wp_rel_ugc
      */
-    public function test_wp_rel_ugc( $input, $output ) {
-        return $this->assertSame( wp_slash( $output ), wp_rel_ugc( $input ) );
+    public function test_wp_rel_ugc( $input, $output, $expect_deprecation = false ) {
+        if ( true === $expect_deprecation && PHP_VERSION_ID >= 80100 ) {
+            /*
+             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
+             * via hooked in filter functions until a more structural solution to the
+             * "missing input validation" conundrum has been architected and implemented.
+             */
+            $this->expectDeprecation();
+            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
+        }
+
+        $this->assertSame( wp_slash( $output ), wp_rel_ugc( $input ) );
     }
 
@@ -40 +70 @@
                 '<a href="">Double Quotes</a>',
                 '<a href="" rel="nofollow ugc">Double Quotes</a>',
+                true,
             ),
             array(
@@ -77 +108 @@
 
     public function test_append_ugc_with_valueless_attribute() {
+        if ( PHP_VERSION_ID >= 80100 ) {
+            /*
+             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
+             * via hooked in filter functions until a more structural solution to the
+             * "missing input validation" conundrum has been architected and implemented.
+             */
+            $this->expectDeprecation();
+            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
+        }
+
         $content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';
         $expected = '<p>This is some cool <a href=\"demo.com\" download rel=\"hola nofollow ugc\">Code</a></p>';