Changeset 51971

Timestamp:

11/01/2021 10:53:19 PM (3 years ago)

Author:

joedolson

Message:

Widgets: Use a text-based button to select location.

The WordPress Events and News widget used an icon-only button to select a location. The Pencil icon alone provided insufficient context and labeling for accessibility. Add text to clearly describe button action and change icon to represent a location marker.

Props AmethystAnswers, sabernhardt.
Fixes #53311.

Location:

trunk/src/wp-admin

Files:

• css/dashboard.css (modified) (1 diff)
• includes/dashboard.php (modified) (1 diff)

trunk/src/wp-admin/css/dashboard.css

@@ -355 +355 @@
 .community-events-loading[aria-hidden="true"],
 .community-events[aria-hidden="true"],
-.community-events [aria-hidden="true"] {
+.community-events form[aria-hidden="true"] {
     display: none;
 }

trunk/src/wp-admin/includes/dashboard.php

@@ -1351 +1351 @@
                 <span id="community-events-location-message"></span>
 
-                <button class="button-link community-events-toggle-location" aria-label="<?php esc_attr_e( 'Edit city' ); ?>" aria-expanded="false">
-                    <span class="dashicons dashicons-edit"></span>
+                <button class="button-link community-events-toggle-location" aria-expanded="false">
+                    <span class="dashicons dashicons-location" aria-hidden="true"></span>
+                    <span class="community-events-location-edit"><?php _e( 'Select location' ); ?></span>
                 </button>
             </p>