Changeset 51975

Timestamp:

11/02/2021 03:56:02 PM (3 years ago)

Author:

johnjamesjacoby

Message:

Admin/Comments: remove bespoke truncation from search string HTML.

This change removes a call to wp_html_excerpt() used on the HTML output of the search string, supplied by the current user in the previous page request via the named s input in the search-box UI.

If the search string is extremely long, it wraps around the available empty space in a way that is not visually displeasing, confirming that truncation is not a requirement here.

This also addresses a small accessibility concern as the non-truncated string was not alternatively presented, and helps normalize the output of $_REQUEST['s'] for more broad improvements in the future.

Props hareesh-pillai, jakubtyrcha, johnjamesjacoby, lukecavanagh, sabernhardt.

Fixes #17636.

File:

• trunk/src/wp-admin/edit-comments.php (modified) (1 diff)

trunk/src/wp-admin/edit-comments.php

@@ -252 +252 @@
         /* translators: %s: Search query. */
         __( 'Search results for: %s' ),
-        '<strong>' . wp_html_excerpt( esc_html( wp_unslash( $_REQUEST['s'] ) ), 50, '&hellip;' ) . '</strong>'
+        '<strong>' . esc_html( wp_unslash( $_REQUEST['s'] ) ) . '</strong>'
     );
     echo '</span>';