Changeset 52002 for trunk/.github/workflows/slack-notifications.yml

Timestamp:

11/03/2021 02:54:20 PM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Pass workflow outcome to Slack Notifications.

When using a workflow as a callable workflow, the job status check functions do not take the called workflow into account. This has caused some failures to be incorrectly reported as successful.

This adds an input to the Slack notifications workflow for when the workflow_call event is used.

See #53363.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (5 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -24 +24 @@
 
   workflow_call:
+    inputs:
+      calling_status:
+        description: 'The status of the calling workflow'
+        type: string
+        required: true
     secrets:
       SLACK_GHA_SUCCESS_WEBHOOK:
@@ -126 +131 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ github.event_name == 'push' && failure() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure' }}
+    if: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure' || inputs.calling_status == 'failure' || failure() }}
 
     steps:
@@ -141 +146 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && ( github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' ) }}
+    if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && ( github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' || inputs.calling_status == 'success' ) && success() }}
 
     steps:
@@ -156 +161 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' }}
+    if: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' || inputs.calling_status == 'success' && success() }}
 
     steps:
@@ -171 +176 @@
     runs-on: ubuntu-latest
     needs: [ prepare ]
-    if: ${{ github.event_name == 'push' && cancelled() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'cancelled' }}
+    if: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'cancelled' || inputs.calling_status == 'cancelled' || cancelled() }}
 
     steps: