Changeset 52009 for trunk/tests/phpunit/includes/utils.php

Timestamp:

11/04/2021 01:15:33 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add public visibility to methods in tests/phpunit/includes/.

This commit adds the public visibility keyword to each method which did not have an explicit visibility keyword.

Why public?

With no visibility previously declared, these methods are implicitly public and available for use. As these are part of the WordPress testing framework (for Core and extenders), changing them to anything else would be a backwards-compatibility break.

Props costdev, jrf, hellofromTonya.
See #54177.

File:

• trunk/tests/phpunit/includes/utils.php (modified) (15 diffs)

trunk/tests/phpunit/includes/utils.php

@@ -65 +65 @@
      * PHP5 constructor.
      */
-    function __construct( $debug = 0 ) {
+    public function __construct( $debug = 0 ) {
         $this->reset();
         $this->debug = $debug;
     }
 
-    function reset() {
+    public function reset() {
         $this->events = array();
     }
 
-    function current_filter() {
+    public function current_filter() {
         if ( is_callable( 'current_filter' ) ) {
             return current_filter();
@@ -82 +82 @@
     }
 
-    function action( $arg ) {
+    public function action( $arg ) {
         if ( $this->debug ) {
             dmp( __FUNCTION__, $this->current_filter() );
@@ -95 +95 @@
     }
 
-    function action2( $arg ) {
+    public function action2( $arg ) {
         if ( $this->debug ) {
             dmp( __FUNCTION__, $this->current_filter() );
@@ -109 +109 @@
     }
 
-    function filter( $arg ) {
+    public function filter( $arg ) {
         if ( $this->debug ) {
             dmp( __FUNCTION__, $this->current_filter() );
@@ -123 +123 @@
     }
 
-    function filter2( $arg ) {
+    public function filter2( $arg ) {
         if ( $this->debug ) {
             dmp( __FUNCTION__, $this->current_filter() );
@@ -137 +137 @@
     }
 
-    function filter_append( $arg ) {
+    public function filter_append( $arg ) {
         if ( $this->debug ) {
             dmp( __FUNCTION__, $this->current_filter() );
@@ -151 +151 @@
     }
 
-    function filterall( $tag, ...$args ) {
+    public function filterall( $tag, ...$args ) {
         // This one doesn't return the result, so it's safe to use with the new 'all' filter.
         if ( $this->debug ) {
@@ -165 +165 @@
 
     // Return a list of all the actions, tags and args.
-    function get_events() {
+    public function get_events() {
         return $this->events;
     }
 
     // Return a count of the number of times the action was called since the last reset.
-    function get_call_count( $tag = '' ) {
+    public function get_call_count( $tag = '' ) {
         if ( $tag ) {
             $count = 0;
@@ -184 +184 @@
 
     // Return an array of the tags that triggered calls to this action.
-    function get_tags() {
+    public function get_tags() {
         $out = array();
         foreach ( $this->events as $e ) {
@@ -193 +193 @@
 
     // Return an array of args passed in calls to this action.
-    function get_args() {
+    public function get_args() {
         $out = array();
         foreach ( $this->events as $e ) {
@@ -211 +211 @@
      * PHP5 constructor.
      */
-    function __construct( $in ) {
+    public function __construct( $in ) {
         $this->xml = xml_parser_create();
         xml_set_object( $this->xml, $this );
@@ -220 +220 @@
     }
 
-    function parse( $in ) {
+    public function parse( $in ) {
         $parse = xml_parse( $this->xml, $in, true );
         if ( ! $parse ) {
@@ -236 +236 @@
     }
 
-    function start_handler( $parser, $name, $attributes ) {
+    public function start_handler( $parser, $name, $attributes ) {
         $data['name'] = $name;
         if ( $attributes ) {
@@ -243 +243 @@
     }
 
-    function data_handler( $parser, $data ) {
+    public function data_handler( $parser, $data ) {
         $index = count( $this->data ) - 1;
 
@@ -252 +252 @@
     }
 
-    function end_handler( $parser, $name ) {
+    public function end_handler( $parser, $name ) {
         if ( count( $this->data ) > 1 ) {
             $data                            = array_pop( $this->data );