Changeset 52010 for trunk/tests/phpunit/tests/actions.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/actions.php (modified) (28 diffs)

trunk/tests/phpunit/tests/actions.php

@@ -11 +11 @@
      * @covers ::do_action
      */
-    function test_simple_action() {
+    public function test_simple_action() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -31 +31 @@
      * @covers ::remove_action
      */
-    function test_remove_action() {
+    public function test_remove_action() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -53 +53 @@
      * @covers ::has_action
      */
-    function test_has_action() {
+    public function test_has_action() {
         $tag  = __FUNCTION__;
         $func = __FUNCTION__ . '_func';
@@ -72 +72 @@
      * @covers ::do_action
      */
-    function test_multiple_actions() {
+    public function test_multiple_actions() {
         $a1  = new MockAction();
         $a2  = new MockAction();
@@ -93 +93 @@
      * @covers ::do_action
      */
-    function test_action_args_1() {
+    public function test_action_args_1() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -113 +113 @@
      * @covers ::do_action
      */
-    function test_action_args_2() {
+    public function test_action_args_2() {
         $a1   = new MockAction();
         $a2   = new MockAction();
@@ -147 +147 @@
      * @covers ::do_action
      */
-    function test_action_args_3() {
+    public function test_action_args_3() {
         $a1   = new MockAction();
         $a2   = new MockAction();
@@ -186 +186 @@
      * @covers ::do_action
      */
-    function test_action_args_with_php4_syntax() {
+    public function test_action_args_with_php4_syntax() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -200 +200 @@
     }
 
-    function test_action_priority() {
+    public function test_action_priority() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -232 +232 @@
      * @covers ::did_action
      */
-    function test_did_action() {
+    public function test_did_action() {
         $tag1 = 'action1';
         $tag2 = 'action2';
@@ -256 +256 @@
      * @covers ::do_action
      */
-    function test_all_action() {
+    public function test_all_action() {
         $a    = new MockAction();
         $tag1 = __FUNCTION__ . '_1';
@@ -283 +283 @@
      * @covers ::remove_action
      */
-    function test_remove_all_action() {
+    public function test_remove_all_action() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -306 +306 @@
      * @covers ::do_action_ref_array
      */
-    function test_action_ref_array() {
+    public function test_action_ref_array() {
         $obj = new stdClass();
         $a   = new MockAction();
@@ -327 +327 @@
      * @covers ::do_action
      */
-    function test_action_keyed_array() {
+    public function test_action_keyed_array() {
         $a = new MockAction();
 
@@ -354 +354 @@
      * @covers ::remove_action
      */
-    function test_action_self_removal() {
+    public function test_action_self_removal() {
         add_action( 'test_action_self_removal', array( $this, 'action_self_removal' ) );
         do_action( 'test_action_self_removal' );
@@ -360 +360 @@
     }
 
-    function action_self_removal() {
+    public function action_self_removal() {
         remove_action( 'test_action_self_removal', array( $this, 'action_self_removal' ) );
     }
@@ -369 +369 @@
      * @covers ::do_action
      */
-    function test_action_recursion() {
+    public function test_action_recursion() {
         $tag = __FUNCTION__;
         $a   = new MockAction();
@@ -386 +386 @@
      * @covers ::do_action
      */
-    function action_that_causes_recursion( $tag ) {
+    public function action_that_causes_recursion( $tag ) {
         static $recursing = false;
         if ( ! $recursing ) {
@@ -402 +402 @@
      * @covers ::add_action
      */
-    function test_action_callback_manipulation_while_running() {
+    public function test_action_callback_manipulation_while_running() {
         $tag = __FUNCTION__;
         $a   = new MockAction();
@@ -424 +424 @@
     }
 
-    function action_that_manipulates_a_running_hook( $tag, $mocks ) {
+    public function action_that_manipulates_a_running_hook( $tag, $mocks ) {
         remove_action( $tag, array( $mocks[1], 'action' ), 12, 2 );
         add_action( $tag, array( $mocks[2], 'action' ), 12, 2 );
@@ -439 +439 @@
      * @covers ::remove_filter
      */
-    function test_remove_anonymous_callback() {
+    public function test_remove_anonymous_callback() {
         $tag = __FUNCTION__;
         $a   = new MockAction();
@@ -476 +476 @@
      * @covers WP_Hook::offsetUnset
      */
-    function test_array_access_of_wp_filter_global() {
+    public function test_array_access_of_wp_filter_global() {
         global $wp_filter;
         $tag = __FUNCTION__;
@@ -504 +504 @@
      * @covers ::current_action
      */
-    function test_current_action() {
+    public function test_current_action() {
         global $wp_current_filter;
         $wp_current_filter[] = 'first';
@@ -517 +517 @@
      * @covers ::doing_filter
      */
-    function test_doing_filter() {
+    public function test_doing_filter() {
         global $wp_current_filter;
         $wp_current_filter = array(); // Set to an empty array first.
@@ -538 +538 @@
      * @covers ::doing_filter
      */
-    function test_doing_action() {
+    public function test_doing_action() {
         global $wp_current_filter;
         $wp_current_filter = array(); // Set to an empty array first.
@@ -559 +559 @@
      * @covers ::doing_filter
      */
-    function test_doing_filter_real() {
+    public function test_doing_filter_real() {
         $this->assertFalse( doing_filter() );            // No filter is passed in, and no filter is being processed.
         $this->assertFalse( doing_filter( 'testing' ) ); // Filter is passed in but not being processed.
@@ -576 +576 @@
     }
 
-    function apply_testing_filter() {
+    public function apply_testing_filter() {
         $this->apply_testing_filter = true;
 
@@ -597 +597 @@
     }
 
-    function apply_testing_nested_filter() {
+    public function apply_testing_nested_filter() {
         $this->apply_testing_nested_filter = true;
         $this->assertTrue( doing_filter() );