Changeset 52010 for trunk/tests/phpunit/tests/admin/includesPlugin.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/admin/includesPlugin.php (modified) (12 diffs)

trunk/tests/phpunit/tests/admin/includesPlugin.php

@@ -13 +13 @@
     }
 
-    function test_get_plugin_data() {
+    public function test_get_plugin_data() {
         $data = get_plugin_data( DIR_TESTDATA . '/plugins/hello.php' );
 
@@ -36 +36 @@
     }
 
-    function test_menu_page_url() {
+    public function test_menu_page_url() {
         $current_user = get_current_user_id();
         wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
@@ -78 +78 @@
      * @dataProvider data_submenu_position
      */
-    function test_submenu_position( $position, $expected_position ) {
+    public function test_submenu_position( $position, $expected_position ) {
         global $submenu;
         global $menu;
@@ -126 +126 @@
      * @dataProvider data_submenu_position
      */
-    function test_submenu_helpers_position( $position, $expected_position ) {
+    public function test_submenu_helpers_position( $position, $expected_position ) {
         global $submenu;
         global $menu;
@@ -228 +228 @@
      * }
      */
-    function submenus_to_add() {
+    private function submenus_to_add() {
         return array(
             array( 'Submenu Position', 'Submenu Position', 'manage_options', 'sub-page', '' ),
@@ -250 +250 @@
      * }
      */
-    function data_submenu_position() {
+    public function data_submenu_position() {
         $menu_count = count( $this->submenus_to_add() );
         return array(
@@ -269 +269 @@
      * @ticket 48599
      */
-    function test_position_when_parent_slug_child_slug_are_the_same() {
+    public function test_position_when_parent_slug_child_slug_are_the_same() {
         global $submenu, $menu;
 
@@ -301 +301 @@
      * @ticket 48599
      */
-    function test_passing_string_as_position_fires_doing_it_wrong() {
+    public function test_passing_string_as_position_fires_doing_it_wrong() {
         $this->setExpectedIncorrectUsage( 'add_submenu_page' );
         global $submenu, $menu;
@@ -325 +325 @@
     }
 
-    function test_is_plugin_active_true() {
+    public function test_is_plugin_active_true() {
         activate_plugin( 'hello.php' );
         $test = is_plugin_active( 'hello.php' );
@@ -333 +333 @@
     }
 
-    function test_is_plugin_active_false() {
+    public function test_is_plugin_active_false() {
         deactivate_plugins( 'hello.php' );
         $test = is_plugin_active( 'hello.php' );
@@ -339 +339 @@
     }
 
-    function test_is_plugin_inactive_true() {
+    public function test_is_plugin_inactive_true() {
         deactivate_plugins( 'hello.php' );
         $test = is_plugin_inactive( 'hello.php' );
@@ -345 +345 @@
     }
 
-    function test_is_plugin_inactive_false() {
+    public function test_is_plugin_inactive_false() {
         activate_plugin( 'hello.php' );
         $test = is_plugin_inactive( 'hello.php' );