Changeset 52010 for trunk/tests/phpunit/tests/admin/includesScreen.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/admin/includesScreen.php (modified) (10 diffs)

trunk/tests/phpunit/tests/admin/includesScreen.php

@@ -156 +156 @@
     );
 
-    function tear_down() {
+    public function tear_down() {
         unset( $GLOBALS['wp_taxonomies']['old-or-new'] );
         parent::tear_down();
     }
 
-    function test_set_current_screen_with_hook_suffix() {
+    public function test_set_current_screen_with_hook_suffix() {
         global $current_screen;
 
@@ -229 +229 @@
     }
 
-    function test_post_type_as_hookname() {
+    public function test_post_type_as_hookname() {
         $screen = convert_to_screen( 'page' );
         $this->assertSame( $screen->post_type, 'page' );
@@ -237 +237 @@
     }
 
-    function test_post_type_with_special_suffix_as_hookname() {
+    public function test_post_type_with_special_suffix_as_hookname() {
         register_post_type( 'value-add' );
         $screen = convert_to_screen( 'value-add' ); // The '-add' part is key.
@@ -252 +252 @@
     }
 
-    function test_taxonomy_with_special_suffix_as_hookname() {
+    public function test_taxonomy_with_special_suffix_as_hookname() {
         register_taxonomy( 'old-or-new', 'post' );
         $screen = convert_to_screen( 'edit-old-or-new' ); // The '-new' part is key.
@@ -261 +261 @@
     }
 
-    function test_post_type_with_edit_prefix() {
+    public function test_post_type_with_edit_prefix() {
         register_post_type( 'edit-some-thing' );
         $screen = convert_to_screen( 'edit-some-thing' );
@@ -276 +276 @@
     }
 
-    function test_post_type_edit_collisions() {
+    public function test_post_type_edit_collisions() {
         register_post_type( 'comments' );
         register_post_type( 'tags' );
@@ -296 +296 @@
     }
 
-    function test_help_tabs() {
+    public function test_help_tabs() {
         $tab      = __FUNCTION__;
         $tab_args = array(
@@ -332 +332 @@
      * @ticket 19828
      */
-    function test_help_tabs_priority() {
+    public function test_help_tabs_priority() {
         $tab_1      = 'tab1';
         $tab_1_args = array(
@@ -428 +428 @@
      * @ticket 25799
      */
-    function test_options() {
+    public function test_options() {
         $option      = __FUNCTION__;
         $option_args = array(
@@ -452 +452 @@
     }
 
-    function test_in_admin() {
+    public function test_in_admin() {
         set_current_screen( 'edit.php' );
         $this->assertTrue( get_current_screen()->in_admin() );