Changeset 52010 for trunk/tests/phpunit/tests/auth.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/auth.php (modified) (16 diffs)

trunk/tests/phpunit/tests/auth.php

@@ -33 +33 @@
         }
 
-        function set_up() {
+        public function set_up() {
                 parent::set_up();
 
@@ -50 +50 @@
         }
 
-        function test_auth_cookie_valid() {
+        public function test_auth_cookie_valid() {
                 $cookie = wp_generate_auth_cookie( self::$user_id, time() + 3600, 'auth' );
                 $this->assertSame( self::$user_id, wp_validate_auth_cookie( $cookie, 'auth' ) );
         }
 
-        function test_auth_cookie_invalid() {
+        public function test_auth_cookie_invalid() {
                 // 3600 or less and +3600 may occur in wp_validate_auth_cookie(),
                 // as an ajax test may have defined DOING_AJAX, failing the test.
@@ -71 +71 @@
         }
 
-        function test_auth_cookie_scheme() {
+        public function test_auth_cookie_scheme() {
                 // Arbitrary scheme name.
                 $cookie = wp_generate_auth_cookie( self::$user_id, time() + 3600, 'foo' );
@@ -84 +84 @@
          * @ticket 23494
          */
-        function test_password_trimming() {
+        public function test_password_trimming() {
                 $passwords_to_test = array(
                         'a password with no trailing or leading spaces',
@@ -109 +109 @@
          * @ticket 24973
          */
-        function test_wp_hash_password_trimming() {
+        public function test_wp_hash_password_trimming() {
 
                 $password = ' pass with leading whitespace';
@@ -130 +130 @@
          * @ticket 29217
          */
-        function test_wp_verify_nonce_with_empty_arg() {
+        public function test_wp_verify_nonce_with_empty_arg() {
                 $this->assertFalse( wp_verify_nonce( '' ) );
                 $this->assertFalse( wp_verify_nonce( null ) );
@@ -138 +138 @@
          * @ticket 29542
          */
-        function test_wp_verify_nonce_with_integer_arg() {
+        public function test_wp_verify_nonce_with_integer_arg() {
                 $this->assertFalse( wp_verify_nonce( 1 ) );
         }
@@ -145 +145 @@
          * @ticket 24030
          */
-        function test_wp_nonce_verify_failed() {
+        public function test_wp_nonce_verify_failed() {
                 $nonce = substr( md5( uniqid() ), 0, 10 );
                 $count = did_action( $this->nonce_failure_hook );
@@ -157 +157 @@
          * @ticket 24030
          */
-        function test_wp_nonce_verify_success() {
+        public function test_wp_nonce_verify_success() {
                 $nonce = wp_create_nonce( 'nonce_test_action' );
                 $count = did_action( $this->nonce_failure_hook );
@@ -203 +203 @@
         }
 
-        function test_password_length_limit() {
+        public function test_password_length_limit() {
                 $limit = str_repeat( 'a', 4096 );
 
@@ -253 +253 @@
          * @ticket 45746
          */
-        function test_user_activation_key_is_saved() {
+        public function test_user_activation_key_is_saved() {
                 $user = get_userdata( $this->user->ID );
                 $key  = get_password_reset_key( $user );
@@ -267 +267 @@
          * @ticket 32429
          */
-        function test_user_activation_key_is_checked() {
+        public function test_user_activation_key_is_checked() {
                 global $wpdb;
 
@@ -305 +305 @@
          * @ticket 32429
          */
-        function test_expired_user_activation_key_is_rejected() {
+        public function test_expired_user_activation_key_is_rejected() {
                 global $wpdb;
 
@@ -328 +328 @@
          * @ticket 32429
          */
-        function test_empty_user_activation_key_fails_key_check() {
+        public function test_empty_user_activation_key_fails_key_check() {
                 // An empty user_activation_key should not allow any key to be accepted.
                 $check = check_password_reset_key( 'key', $this->user->user_login );
@@ -341 +341 @@
          * @ticket 32429
          */
-        function test_legacy_user_activation_key_is_rejected() {
+        public function test_legacy_user_activation_key_is_rejected() {
                 global $wpdb;
 
@@ -371 +371 @@
          * @ticket 24783
          */
-        function test_plaintext_user_activation_key_is_rejected() {
+        public function test_plaintext_user_activation_key_is_rejected() {
                 global $wpdb;