Changeset 52010 for trunk/tests/phpunit/tests/basic.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/basic.php (modified) (6 diffs)

trunk/tests/phpunit/tests/basic.php

@@ -8 +8 @@
 class Tests_Basic extends WP_UnitTestCase {
 
-        function test_license() {
+        public function test_license() {
                 // This test is designed to only run on trunk/master.
                 $this->skipOnAutomatedBranches();
@@ -18 +18 @@
         }
 
-        function test_security_md() {
+        public function test_security_md() {
                 // This test is designed to only run on trunk/master.
                 $this->skipOnAutomatedBranches();
@@ -29 +29 @@
         }
 
-        function test_package_json() {
+        public function test_package_json() {
                 $package_json    = file_get_contents( dirname( ABSPATH ) . '/package.json' );
                 $package_json    = json_decode( $package_json, true );
@@ -44 +44 @@
          * @depends test_package_json
          */
-        function test_package_json_node_engine( $package_json ) {
+        public function test_package_json_node_engine( $package_json ) {
                 $this->assertArrayHasKey( 'engines', $package_json );
                 $this->assertArrayHasKey( 'node', $package_json['engines'] );
@@ -51 +51 @@
         // Test some helper utility functions.
 
-        function test_strip_ws() {
+        public function test_strip_ws() {
                 $this->assertSame( '', strip_ws( '' ) );
                 $this->assertSame( 'foo', strip_ws( 'foo' ) );
@@ -78 +78 @@
         }
 
-        function test_mask_input_value() {
+        public function test_mask_input_value() {
                 $in = <<<EOF
 <h2>Assign Authors</h2>