Changeset 52010 for trunk/tests/phpunit/tests/blocks/wpBlock.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/blocks/wpBlock.php (modified) (15 diffs)

trunk/tests/phpunit/tests/blocks/wpBlock.php

@@ -42 +42 @@
         }
 
-        function filter_render_block( $content, $parsed_block ) {
+        public function filter_render_block( $content, $parsed_block ) {
                 return 'Original: "' . $content . '", from block "' . $parsed_block['blockName'] . '"';
         }
@@ -49 +49 @@
          * @ticket 49927
          */
-        function test_constructor_assigns_properties_from_parsed_block() {
+        public function test_constructor_assigns_properties_from_parsed_block() {
                 $this->registry->register( 'core/example', array() );
 
@@ -67 +67 @@
          * @ticket 49927
          */
-        function test_constructor_assigns_block_type_from_registry() {
+        public function test_constructor_assigns_block_type_from_registry() {
                 $block_type_settings = array(
                         'attributes' => array(
@@ -92 +92 @@
          * @ticket 49927
          */
-        function test_lazily_assigns_attributes_with_defaults() {
+        public function test_lazily_assigns_attributes_with_defaults() {
                 $this->registry->register(
                         'core/example',
@@ -126 +126 @@
          * @ticket 49927
          */
-        function test_lazily_assigns_attributes_with_only_defaults() {
+        public function test_lazily_assigns_attributes_with_only_defaults() {
                 $this->registry->register(
                         'core/example',
@@ -154 +154 @@
          * @ticket 49927
          */
-        function test_constructor_assigns_context_from_block_type() {
+        public function test_constructor_assigns_context_from_block_type() {
                 $this->registry->register(
                         'core/example',
@@ -175 +175 @@
          * @ticket 49927
          */
-        function test_constructor_maps_inner_blocks() {
+        public function test_constructor_maps_inner_blocks() {
                 $this->registry->register( 'core/example', array() );
 
@@ -191 +191 @@
          * @ticket 49927
          */
-        function test_constructor_prepares_context_for_inner_blocks() {
+        public function test_constructor_prepares_context_for_inner_blocks() {
                 $this->registry->register(
                         'core/outer',
@@ -227 +227 @@
          * @ticket 49927
          */
-        function test_constructor_assigns_merged_context() {
+        public function test_constructor_assigns_merged_context() {
                 $this->registry->register(
                         'core/example',
@@ -271 +271 @@
          * @ticket 49927
          */
-        function test_render_static_block_type_returns_own_content() {
+        public function test_render_static_block_type_returns_own_content() {
                 $this->registry->register( 'core/static', array() );
                 $this->registry->register(
@@ -293 +293 @@
          * @ticket 49927
          */
-        function test_render_passes_block_for_render_callback() {
+        public function test_render_passes_block_for_render_callback() {
                 $this->registry->register(
                         'core/greeting',
@@ -314 +314 @@
          * @ticket 49927
          */
-        function test_render_applies_render_block_filter() {
+        public function test_render_applies_render_block_filter() {
                 $this->registry->register( 'core/example', array() );
 
@@ -334 +334 @@
          * @ticket 46187
          */
-        function test_render_applies_dynamic_render_block_filter() {
+        public function test_render_applies_dynamic_render_block_filter() {
                 $this->registry->register( 'core/example', array() );
 
@@ -354 +354 @@
          * @ticket 49927
          */
-        function test_passes_attributes_to_render_callback() {
+        public function test_passes_attributes_to_render_callback() {
                 $this->registry->register(
                         'core/greeting',
@@ -388 +388 @@
          * @ticket 49927
          */
-        function test_passes_content_to_render_callback() {
+        public function test_passes_content_to_render_callback() {
                 $this->registry->register(
                         'core/outer',