Make WordPress Core


Ignore:
Timestamp:
11/04/2021 03:22:47 PM (3 years ago)
Author:
hellofromTonya
Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/canonical/customRules.php

    r51568 r52010  
    88class Tests_Canonical_CustomRules extends WP_Canonical_UnitTestCase {
    99
    10     function set_up() {
     10    public function set_up() {
    1111        parent::set_up();
    1212        global $wp_rewrite;
     
    1919     * @dataProvider data
    2020     */
    21     function test( $test_url, $expected, $ticket = 0, $expected_doing_it_wrong = array() ) {
     21    public function test( $test_url, $expected, $ticket = 0, $expected_doing_it_wrong = array() ) {
    2222        $this->assertCanonical( $test_url, $expected, $ticket, $expected_doing_it_wrong );
    2323    }
    2424
    25     function data() {
     25    public function data() {
    2626        /*
    2727         * Data format:
Note: See TracChangeset for help on using the changeset viewer.