Changeset 52010 for trunk/tests/phpunit/tests/canonical/noRewrite.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/canonical/noRewrite.php (modified) (1 diff)

trunk/tests/phpunit/tests/canonical/noRewrite.php

@@ -25 +25 @@
      * @dataProvider data
      */
-    function test( $test_url, $expected, $ticket = 0, $expected_doing_it_wrong = array() ) {
+    public function test( $test_url, $expected, $ticket = 0, $expected_doing_it_wrong = array() ) {
         $this->assertCanonical( $test_url, $expected, $ticket, $expected_doing_it_wrong );
     }
 
-    function data() {
+    public function data() {
         /*
          * Test URL.