Changeset 52010 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (12 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -1285 +1285 @@
     }
 
-    function test_get_comments_for_post() {
+    public function test_get_comments_for_post() {
         $limit = 5;
 
@@ -1345 +1345 @@
      * @ticket 21003
      */
-    function test_orderby_meta() {
+    public function test_orderby_meta() {
         $comment_id  = self::factory()->comment->create( array( 'comment_post_ID' => self::$post_id ) );
         $comment_id2 = self::factory()->comment->create( array( 'comment_post_ID' => self::$post_id ) );
@@ -1597 +1597 @@
      * @ticket 27064
      */
-    function test_get_comments_by_user() {
+    public function test_get_comments_by_user() {
         $users = self::factory()->user->create_many( 2 );
         self::factory()->comment->create(
@@ -1690 +1690 @@
      * @ticket 28434
      */
-    function test_fields_ids_query() {
+    public function test_fields_ids_query() {
         $comment_1 = self::factory()->comment->create(
             array(
@@ -1726 +1726 @@
      * @ticket 29189
      */
-    function test_fields_comment__in() {
+    public function test_fields_comment__in() {
         $comment_1 = self::factory()->comment->create(
             array(
@@ -1762 +1762 @@
      * @ticket 29189
      */
-    function test_fields_comment__not_in() {
+    public function test_fields_comment__not_in() {
         $comment_1 = self::factory()->comment->create(
             array(
@@ -1798 +1798 @@
      * @ticket 29189
      */
-    function test_fields_post__in() {
+    public function test_fields_post__in() {
         $p1 = self::factory()->post->create();
         $p2 = self::factory()->post->create();
@@ -1838 +1838 @@
      * @ticket 29189
      */
-    function test_fields_post__not_in() {
+    public function test_fields_post__not_in() {
         $p1 = self::factory()->post->create();
         $p2 = self::factory()->post->create();
@@ -1878 +1878 @@
      * @ticket 29885
      */
-    function test_fields_post_author__in() {
+    public function test_fields_post_author__in() {
         $author_id1 = 105;
         $author_id2 = 106;
@@ -1921 +1921 @@
      * @ticket 29885
      */
-    function test_fields_post_author__not_in() {
+    public function test_fields_post_author__not_in() {
         $author_id1 = 111;
         $author_id2 = 112;
@@ -1964 +1964 @@
          * @ticket 29885
          */
-    function test_fields_author__in() {
+    public function test_fields_author__in() {
         $p1 = self::factory()->post->create();
         $p2 = self::factory()->post->create();
@@ -2012 +2012 @@
          * @ticket 29885
          */
-    function test_fields_author__not_in() {
+    public function test_fields_author__not_in() {
         $p1 = self::factory()->post->create();
         $p2 = self::factory()->post->create();