Changeset 52010 for trunk/tests/phpunit/tests/comment/template.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/comment/template.php (modified) (7 diffs)

trunk/tests/phpunit/tests/comment/template.php

@@ -20 +20 @@
         }
 
-        function test_get_comments_number() {
+        public function test_get_comments_number() {
                 $post_id = self::$post_id;
 
@@ -33 +33 @@
         }
 
-        function test_get_comments_number_without_arg() {
+        public function test_get_comments_number_without_arg() {
                 $post_id   = self::$post_id;
                 $permalink = get_permalink( $post_id );
@@ -49 +49 @@
          * @ticket 48772
          */
-        function test_get_comments_number_text_with_post_id() {
+        public function test_get_comments_number_text_with_post_id() {
                 $post_id = self::$post_id;
                 $this->factory->comment->create_post_comments( $post_id, 6 );
@@ -68 +68 @@
          * @ticket 13651
          */
-        function test_get_comments_number_text_declension_with_default_args() {
+        public function test_get_comments_number_text_declension_with_default_args() {
                 $post_id   = self::$post_id;
                 $permalink = get_permalink( $post_id );
@@ -91 +91 @@
          * @dataProvider data_get_comments_number_text_declension
          */
-        function test_get_comments_number_text_declension_with_custom_args( $number, $input, $output ) {
+        public function test_get_comments_number_text_declension_with_custom_args( $number, $input, $output ) {
                 $post_id   = self::$post_id;
                 $permalink = get_permalink( $post_id );
@@ -98 +98 @@
                 $this->go_to( $permalink );
 
-                add_filter( 'gettext_with_context', array( $this, '_enable_comment_number_declension' ), 10, 4 );
+                add_filter( 'gettext_with_context', array( $this, 'enable_comment_number_declension' ), 10, 4 );
 
                 $this->assertSame( $output, get_comments_number_text( false, false, $input ) );
 
-                remove_filter( 'gettext_with_context', array( $this, '_enable_comment_number_declension' ), 10, 4 );
+                remove_filter( 'gettext_with_context', array( $this, 'enable_comment_number_declension' ), 10, 4 );
         }
 
-        function _enable_comment_number_declension( $translation, $text, $context, $domain ) {
+        public function enable_comment_number_declension( $translation, $text, $context, $domain ) {
                 if ( 'Comment number declension: on or off' === $context ) {
                         $translation = 'on';
@@ -124 +124 @@
          * }
          */
-        function data_get_comments_number_text_declension() {
+        public function data_get_comments_number_text_declension() {
                 return array(
                         array(