Changeset 52010 for trunk/tests/phpunit/tests/customize/custom-css-setting.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/customize/custom-css-setting.php (modified) (13 diffs)

trunk/tests/phpunit/tests/customize/custom-css-setting.php

@@ -28 +28 @@
      * @see WP_UnitTestCase::setup()
      */
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
@@ -55 +55 @@
      * Tear down the test case.
      */
-    function tear_down() {
+    public function tear_down() {
         $this->setting = null;
         parent::tear_down();
@@ -63 +63 @@
      * Delete the $wp_customize global when cleaning up scope.
      */
-    function clean_up_global_scope() {
+    public function clean_up_global_scope() {
         global $wp_customize;
         $wp_customize = null;
@@ -78 +78 @@
      * @covers WP_Customize_Custom_CSS_Setting::__construct
      */
-    function test_construct() {
+    public function test_construct() {
         $this->assertTrue( post_type_exists( 'custom_css' ) );
         $this->assertSame( 'custom_css', $this->setting->type );
@@ -111 +111 @@
      * @covers WP_Customize_Custom_CSS_Setting::update
      */
-    function test_crud() {
+    public function test_crud() {
 
         $this->setting->default = '/* Hello World */';
@@ -212 +212 @@
      * @ticket 39032
      */
-    function test_custom_css_revision_saved() {
+    public function test_custom_css_revision_saved() {
         $inserted_css = 'body { background: black; }';
         $updated_css  = 'body { background: red; }';
@@ -246 +246 @@
      * @ticket 39259
      */
-    function test_get_custom_css_post_queries_after_failed_lookup() {
+    public function test_get_custom_css_post_queries_after_failed_lookup() {
         set_theme_mod( 'custom_css_post_id', -1 );
         $queries_before = get_num_queries();
@@ -258 +258 @@
      * @ticket 39259
      */
-    function test_update_custom_css_updates_theme_mod() {
+    public function test_update_custom_css_updates_theme_mod() {
         set_theme_mod( 'custom_css_post_id', -1 );
         $post = wp_update_custom_css_post( 'body { background: blue; }' );
@@ -269 +269 @@
      * @covers WP_Customize_Custom_CSS_Setting::value
      */
-    function test_value_filter() {
+    public function test_value_filter() {
         add_filter( 'customize_value_custom_css', array( $this, 'filter_value' ), 10, 2 );
         $this->setting->default = '/*default*/';
@@ -298 +298 @@
      * @return string
      */
-    function filter_value( $value, $setting ) {
+    public function filter_value( $value, $setting ) {
         $this->assertInstanceOf( 'WP_Customize_Custom_CSS_Setting', $setting );
         $value .= '/*filtered*/';
@@ -309 +309 @@
      * @covers WP_Customize_Custom_CSS_Setting::update
      */
-    function test_update_filter() {
+    public function test_update_filter() {
         $original_css = 'body { color:red; }';
         $post_id      = $this->factory()->post->create(
@@ -344 +344 @@
      * @return array Data.
      */
-    function filter_update_custom_css_data( $data, $args ) {
+    public function filter_update_custom_css_data( $data, $args ) {
         $this->assertIsArray( $data );
         $this->assertSameSets( array( 'css', 'preprocessed' ), array_keys( $data ) );
@@ -367 +367 @@
      * @covers WP_Customize_Custom_CSS_Setting::validate
      */
-    function test_validate() {
+    public function test_validate() {
 
         // Empty CSS throws no errors.