Changeset 52010 for trunk/tests/phpunit/tests/customize/nav-menu-setting.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/customize/nav-menu-setting.php (modified) (16 diffs)

trunk/tests/phpunit/tests/customize/nav-menu-setting.php

@@ -20 +20 @@
      * @see WP_UnitTestCase::setup()
      */
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
@@ -33 +33 @@
      * Delete the $wp_customize global when cleaning up scope.
      */
-    function clean_up_global_scope() {
+    public function clean_up_global_scope() {
         global $wp_customize;
         $wp_customize = null;
@@ -44 +44 @@
      * @return array
      */
-    function get_nav_menu_items_option() {
+    private function get_nav_menu_items_option() {
         return get_option( 'nav_menu_options', array( 'auto_add' => array() ) );
     }
@@ -51 +51 @@
      * Test constants and statics.
      */
-    function test_constants() {
+    public function test_constants() {
         do_action( 'customize_register', $this->wp_customize );
         $this->assertTrue( taxonomy_exists( WP_Customize_Nav_Menu_Setting::TAXONOMY ) );
@@ -61 +61 @@
      * @see WP_Customize_Nav_Menu_Setting::__construct()
      */
-    function test_construct() {
+    public function test_construct() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -92 +92 @@
      * Test empty constructor.
      */
-    function test_construct_empty_menus() {
+    public function test_construct_empty_menus() {
         do_action( 'customize_register', $this->wp_customize );
         $_wp_customize = $this->wp_customize;
@@ -112 +112 @@
      * @see WP_Customize_Nav_Menu_Setting::__construct()
      */
-    function test_construct_placeholder() {
+    public function test_construct_placeholder() {
         do_action( 'customize_register', $this->wp_customize );
         $default = array(
@@ -129 +129 @@
      * @see WP_Customize_Nav_Menu_Setting::value()
      */
-    function test_value() {
+    public function test_value() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -169 +169 @@
      * @see WP_Customize_Nav_Menu_Setting::preview()
      */
-    function test_preview_updated() {
+    public function test_preview_updated() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -236 +236 @@
      * @see WP_Customize_Nav_Menu_Setting::preview()
      */
-    function test_preview_inserted() {
+    public function test_preview_inserted() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -281 +281 @@
      * @see WP_Customize_Nav_Menu_Setting::preview()
      */
-    function test_preview_deleted() {
+    public function test_preview_deleted() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -320 +320 @@
      * @see WP_Customize_Nav_Menu_Setting::sanitize()
      */
-    function test_sanitize() {
+    public function test_sanitize() {
         do_action( 'customize_register', $this->wp_customize );
         $setting = new WP_Customize_Nav_Menu_Setting( $this->wp_customize, 'nav_menu[123]' );
@@ -351 +351 @@
      * @see WP_Customize_Nav_Menu_Setting::update()
      */
-    function test_save_updated() {
+    public function test_save_updated() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -416 +416 @@
      * @see WP_Customize_Nav_Menu_Setting::update()
      */
-    function test_save_inserted() {
+    public function test_save_inserted() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -465 +465 @@
      * @see WP_Customize_Nav_Menu_Setting::update()
      */
-    function test_save_inserted_conflicted_name() {
+    public function test_save_inserted_conflicted_name() {
         do_action( 'customize_register', $this->wp_customize );
 
@@ -490 +490 @@
      * @see WP_Customize_Nav_Menu_Setting::update()
      */
-    function test_save_deleted() {
+    public function test_save_deleted() {
         do_action( 'customize_register', $this->wp_customize );