Changeset 52010 for trunk/tests/phpunit/tests/customize/partial.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/customize/partial.php (modified) (17 diffs)

trunk/tests/phpunit/tests/customize/partial.php

@@ -30 +30 @@
          * Set up.
          */
-        function set_up() {
+        public function set_up() {
                 parent::set_up();
                 require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
@@ -45 +45 @@
          * @see WP_Customize_Partial::__construct()
          */
-        function test_construct_default_args() {
+        public function test_construct_default_args() {
                 $partial_id = 'blogname';
                 $partial    = new WP_Customize_Partial( $this->selective_refresh, $partial_id );
@@ -65 +65 @@
          * @return string|false Content or false if error.
          */
-        function render_post_content_partial( $partial ) {
+        public function render_post_content_partial( $partial ) {
                 $id_data = $partial->id_data();
                 $post_id = (int) $id_data['keys'][0];
@@ -83 +83 @@
          * @see WP_Customize_Partial::__construct()
          */
-        function test_construct_non_default_args() {
+        public function test_construct_non_default_args() {
 
                 $post_id = self::factory()->post->create(
@@ -130 +130 @@
          * @see WP_Customize_Partial::id_data()
          */
-        function test_id_data() {
+        public function test_id_data() {
                 $partial = new WP_Customize_Partial( $this->selective_refresh, 'foo' );
                 $id_data = $partial->id_data();
@@ -164 +164 @@
          * @return string|false Content.
          */
-        function filter_customize_partial_render( $rendered, $partial, $container_context ) {
+        public function filter_customize_partial_render( $rendered, $partial, $container_context ) {
                 $this->assertTrue( false === $rendered || is_string( $rendered ) );
                 $this->assertInstanceOf( 'WP_Customize_Partial', $partial );
@@ -180 +180 @@
          * @return string|false Content.
          */
-        function filter_customize_partial_render_with_id( $rendered, $partial, $container_context ) {
+        public function filter_customize_partial_render_with_id( $rendered, $partial, $container_context ) {
                 $this->assertSame( sprintf( 'customize_partial_render_%s', $partial->id ), current_filter() );
                 $this->assertTrue( false === $rendered || is_string( $rendered ) );
@@ -194 +194 @@
          * @return string Content.
          */
-        function render_echo_and_return() {
+        public function render_echo_and_return() {
                 echo 'foo';
                 return 'bar';
@@ -202 +202 @@
          * Echo render_callback().
          */
-        function render_echo() {
+        public function render_echo() {
                 echo 'foo';
         }
@@ -211 +211 @@
          * @return string Content.
          */
-        function render_return() {
+        public function render_return() {
                 return 'bar';
         }
@@ -220 +220 @@
          * @see WP_Customize_Partial::render()
          */
-        function test_render_with_bad_callback_should_give_preference_to_return_value() {
+        public function test_render_with_bad_callback_should_give_preference_to_return_value() {
                 $partial = new WP_Customize_Partial(
                         $this->selective_refresh,
@@ -237 +237 @@
          * @see WP_Customize_Partial::render()
          */
-        function test_render_echo_callback() {
+        public function test_render_echo_callback() {
                 $partial                                       = new WP_Customize_Partial(
                         $this->selective_refresh,
@@ -260 +260 @@
          * @see WP_Customize_Partial::render()
          */
-        function test_render_return_callback() {
+        public function test_render_return_callback() {
                 $partial                                       = new WP_Customize_Partial(
                         $this->selective_refresh,
@@ -283 +283 @@
          * @see WP_Customize_Partial::render_callback()
          */
-        function test_render_callback_default() {
+        public function test_render_callback_default() {
                 $partial = new WP_Customize_Partial( $this->selective_refresh, 'foo' );
                 $this->assertFalse( $partial->render_callback( $partial, array() ) );
@@ -294 +294 @@
          * @see WP_Customize_Partial::json()
          */
-        function test_json() {
+        public function test_json() {
                 $post_id    = 123;
                 $partial_id = sprintf( 'post_content[%d]', $post_id );
@@ -322 +322 @@
          * @see WP_Customize_Partial::check_capabilities()
          */
-        function test_check_capabilities() {
+        public function test_check_capabilities() {
                 wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
                 do_action( 'customize_register', $this->wp_customize );
@@ -391 +391 @@
          * Tear down.
          */
-        function tear_down() {
+        public function tear_down() {
                 $this->wp_customize = null;
                 unset( $GLOBALS['wp_customize'] );