Changeset 52010 for trunk/tests/phpunit/tests/customize/setting.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/customize/setting.php (modified) (18 diffs)

trunk/tests/phpunit/tests/customize/setting.php

@@ -18 +18 @@
     public $undefined;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
@@ -26 +26 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         $this->manager = null;
         unset( $GLOBALS['wp_customize'] );
@@ -32 +32 @@
     }
 
-    function test_constructor_without_args() {
+    public function test_constructor_without_args() {
         $setting = new WP_Customize_Setting( $this->manager, 'foo' );
         $this->assertSame( $this->manager, $setting->manager );
@@ -85 +85 @@
      * @param WP_Customize_Setting $setting The setting object.
      */
-    function sanitize_js_callback_base64_for_testing( $value, $setting ) {
+    public function sanitize_js_callback_base64_for_testing( $value, $setting ) {
         return base64_encode( $value );
     }
 
-    function test_constructor_with_args() {
+    public function test_constructor_with_args() {
         $args    = array(
             'type'                 => 'option',
@@ -137 +137 @@
      * @see WP_Customize_Setting::value()
      */
-    function test_preview_standard_types_non_multidimensional() {
+    public function test_preview_standard_types_non_multidimensional() {
         wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
         $_POST['customized'] = wp_slash( wp_json_encode( $this->post_data_overrides ) );
@@ -216 +216 @@
      * @see WP_Customize_Setting::value()
      */
-    function test_preview_standard_types_multidimensional() {
+    public function test_preview_standard_types_multidimensional() {
         wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
         $_POST['customized'] = wp_slash( wp_json_encode( $this->post_data_overrides ) );
@@ -317 +317 @@
     protected $custom_type_data_previewed;
 
-    function custom_type_getter( $name, $default = null ) {
+    private function custom_type_getter( $name, $default = null ) {
         if ( did_action( "customize_preview_{$name}" ) && array_key_exists( $name, $this->custom_type_data_previewed ) ) {
             $value = $this->custom_type_data_previewed[ $name ];
@@ -328 +328 @@
     }
 
-    function custom_type_setter( $name, $value ) {
+    private function custom_type_setter( $name, $value ) {
         $this->custom_type_data_saved[ $name ] = $value;
     }
@@ -340 +340 @@
      * @return mixed|null
      */
-    function custom_type_value_filter( $default, $setting = null ) {
+    public function custom_type_value_filter( $default, $setting = null ) {
         $name = preg_replace( '/^customize_value_/', '', current_filter() );
         $this->assertInstanceOf( 'WP_Customize_Setting', $setting );
@@ -351 +351 @@
      * @param WP_Customize_Setting $setting
      */
-    function custom_type_preview( $setting ) {
+    public function custom_type_preview( $setting ) {
         $previewed_value = $setting->post_value( $this->undefined );
         if ( $this->undefined !== $previewed_value ) {
@@ -362 +362 @@
      * @see WP_Customize_Setting::preview()
      */
-    function test_preview_custom_type() {
+    public function test_preview_custom_type() {
         wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
         $type                = 'custom_type';
@@ -474 +474 @@
      * @ticket 30988
      */
-    function test_non_posted_setting_applying_default_value_in_preview() {
+    public function test_non_posted_setting_applying_default_value_in_preview() {
         $type    = 'option';
         $name    = 'unset_option_without_post_value';
@@ -492 +492 @@
      * @see WP_Customize_Setting::update()
      */
-    function test_update_custom_type() {
+    public function test_update_custom_type() {
         $type    = 'custom';
         $name    = 'foo';
@@ -527 +527 @@
      * @param WP_Customize_Setting $setting
      */
-    function handle_customize_update_custom_foo_action( $value, $setting = null ) {
+    public function handle_customize_update_custom_foo_action( $value, $setting = null ) {
         $this->assertSame( 'hello world \\o/', $value );
         $this->assertInstanceOf( 'WP_Customize_Setting', $setting );
@@ -538 +538 @@
      * @param WP_Customize_Setting $setting
      */
-    function handle_customize_save_custom_foo_action( $setting ) {
+    public function handle_customize_save_custom_foo_action( $setting ) {
         $this->assertInstanceOf( 'WP_Customize_Setting', $setting );
         $this->assertSame( 'custom', $setting->type );
@@ -551 +551 @@
      * @ticket 31428
      */
-    function test_is_current_blog_previewed() {
+    public function test_is_current_blog_previewed() {
         wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
         $type       = 'option';
@@ -573 +573 @@
      * @group ms-required
      */
-    function test_previewing_with_switch_to_blog() {
+    public function test_previewing_with_switch_to_blog() {
         wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
         $type       = 'option';
@@ -595 +595 @@
      * @ticket 33499
      */
-    function test_option_autoloading() {
+    public function test_option_autoloading() {
         global $wpdb;
         wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );