Changeset 52010 for trunk/tests/phpunit/tests/dbdelta.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/dbdelta.php (modified) (21 diffs)

trunk/tests/phpunit/tests/dbdelta.php

@@ -406 +406 @@
      * @ticket 31869
      */
-    function test_truncated_index() {
+    public function test_truncated_index() {
         global $wpdb;
 
@@ -446 +446 @@
      * @ticket 36748
      */
-    function test_dont_downsize_text_fields() {
+    public function test_dont_downsize_text_fields() {
         global $wpdb;
 
@@ -471 +471 @@
      * @ticket 36748
      */
-    function test_dont_downsize_blob_fields() {
+    public function test_dont_downsize_blob_fields() {
         global $wpdb;
 
@@ -496 +496 @@
      * @ticket 36748
      */
-    function test_upsize_text_fields() {
+    public function test_upsize_text_fields() {
         global $wpdb;
 
@@ -527 +527 @@
      * @ticket 36748
      */
-    function test_upsize_blob_fields() {
+    public function test_upsize_blob_fields() {
         global $wpdb;
 
@@ -558 +558 @@
      * @ticket 20263
      */
-    function test_query_with_backticks_does_not_throw_an_undefined_index_warning() {
+    public function test_query_with_backticks_does_not_throw_an_undefined_index_warning() {
         global $wpdb;
 
@@ -583 +583 @@
      * @ticket 36948
      */
-    function test_spatial_indices() {
+    public function test_spatial_indices() {
         global $wpdb;
 
@@ -644 +644 @@
      * @ticket 20263
      */
-    function test_query_with_backticks_does_not_cause_a_query_to_alter_all_columns_and_indices_to_run_even_if_none_have_changed() {
+    public function test_query_with_backticks_does_not_cause_a_query_to_alter_all_columns_and_indices_to_run_even_if_none_have_changed() {
         global $wpdb;
 
@@ -673 +673 @@
      * @ticket 20263
      */
-    function test_index_with_a_reserved_keyword_can_be_created() {
+    public function test_index_with_a_reserved_keyword_can_be_created() {
         global $wpdb;
 
@@ -709 +709 @@
      * @ticket 20263
      */
-    function test_wp_get_db_schema_does_no_alter_queries_on_existing_install() {
+    public function test_wp_get_db_schema_does_no_alter_queries_on_existing_install() {
         $updates = dbDelta( wp_get_db_schema() );
 
@@ -718 +718 @@
      * @ticket 20263
      */
-    function test_key_and_index_and_fulltext_key_and_fulltext_index_and_unique_key_and_unique_index_indicies() {
+    public function test_key_and_index_and_fulltext_key_and_fulltext_index_and_unique_key_and_unique_index_indicies() {
         global $wpdb;
 
@@ -756 +756 @@
      * @ticket 20263
      */
-    function test_index_and_key_are_synonyms_and_do_not_recreate_indices() {
+    public function test_index_and_key_are_synonyms_and_do_not_recreate_indices() {
         global $wpdb;
 
@@ -780 +780 @@
      * @ticket 20263
      */
-    function test_indices_with_prefix_limits_are_created_and_do_not_recreate_indices() {
+    public function test_indices_with_prefix_limits_are_created_and_do_not_recreate_indices() {
         global $wpdb;
 
@@ -814 +814 @@
      * @ticket 34959
      */
-    function test_index_col_names_with_order_do_not_recreate_indices() {
+    public function test_index_col_names_with_order_do_not_recreate_indices() {
         global $wpdb;
 
@@ -838 +838 @@
      * @ticket 34873
      */
-    function test_primary_key_with_single_space_does_not_recreate_index() {
+    public function test_primary_key_with_single_space_does_not_recreate_index() {
         global $wpdb;
 
@@ -862 +862 @@
      * @ticket 34869
      */
-    function test_index_definitions_with_spaces_do_not_recreate_indices() {
+    public function test_index_definitions_with_spaces_do_not_recreate_indices() {
         global $wpdb;
 
@@ -886 +886 @@
      * @ticket 34871
      */
-    function test_index_types_are_not_case_sensitive_and_do_not_recreate_indices() {
+    public function test_index_types_are_not_case_sensitive_and_do_not_recreate_indices() {
         global $wpdb;
 
@@ -910 +910 @@
      * @ticket 34874
      */
-    function test_key_names_are_not_case_sensitive_and_do_not_recreate_indices() {
+    public function test_key_names_are_not_case_sensitive_and_do_not_recreate_indices() {
         global $wpdb;
 
@@ -935 +935 @@
      * @ticket 34870
      */
-    function test_unchanged_key_lengths_do_not_recreate_index() {
+    public function test_unchanged_key_lengths_do_not_recreate_index() {
         global $wpdb;
 
@@ -960 +960 @@
      * @ticket 34870
      */
-    function test_changed_key_lengths_do_not_recreate_index() {
+    public function test_changed_key_lengths_do_not_recreate_index() {
         global $wpdb;
 
@@ -1044 +1044 @@
      * @ticket 31679
      */
-    function test_column_type_change_with_hyphens_in_name() {
+    public function test_column_type_change_with_hyphens_in_name() {
         global $wpdb;