Changeset 52010 for trunk/tests/phpunit/tests/dependencies/styles.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/dependencies/styles.php (modified) (13 diffs)

trunk/tests/phpunit/tests/dependencies/styles.php

@@ -13 +13 @@
     private $old_wp_scripts;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -38 +38 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         $GLOBALS['wp_styles']  = $this->old_wp_styles;
         $GLOBALS['wp_scripts'] = $this->old_wp_scripts;
@@ -57 +57 @@
      * @ticket 11315
      */
-    function test_wp_enqueue_style() {
+    public function test_wp_enqueue_style() {
         wp_enqueue_style( 'no-deps-no-version', 'example.com' );
         wp_enqueue_style( 'no-deps-version', 'example.com', array(), 1.2 );
@@ -78 +78 @@
      * @ticket 42804
      */
-    function test_wp_enqueue_style_with_html5_support_does_not_contain_type_attribute() {
+    public function test_wp_enqueue_style_with_html5_support_does_not_contain_type_attribute() {
         add_theme_support( 'html5', array( 'style' ) );
 
@@ -286 +286 @@
      * @ticket 31126
      */
-    function test_wp_register_style() {
+    public function test_wp_register_style() {
         $this->assertTrue( wp_register_style( 'duplicate-handler', 'http://example.com' ) );
         $this->assertFalse( wp_register_style( 'duplicate-handler', 'http://example.com' ) );
@@ -294 +294 @@
      * @ticket 35229
      */
-    function test_wp_add_inline_style_for_handle_without_source() {
+    public function test_wp_add_inline_style_for_handle_without_source() {
         $style = 'a { color: blue; }';
 
@@ -317 +317 @@
      * @dataProvider data_styles_with_media
      */
-    function test_wp_enqueue_style_with_media( $expected, $media ) {
+    public function test_wp_enqueue_style_with_media( $expected, $media ) {
         wp_enqueue_style( 'handle', 'http://example.com', array(), 1, $media );
         $this->assertStringContainsString( $expected, get_echo( 'wp_print_styles' ) );
     }
 
-    function data_styles_with_media() {
+    public function data_styles_with_media() {
         return array(
             array(
@@ -358 +358 @@
      * @covers ::wp_enqueue_style
      */
-    function test_block_styles_for_editing_without_theme_support() {
+    public function test_block_styles_for_editing_without_theme_support() {
         // Confirm we are without theme support by default.
         $this->assertFalse( current_theme_supports( 'wp-block-styles' ) );
@@ -376 +376 @@
      * @covers ::wp_common_block_scripts_and_styles
      */
-    function test_block_styles_for_editing_with_theme_support() {
+    public function test_block_styles_for_editing_with_theme_support() {
         add_theme_support( 'wp-block-styles' );
 
@@ -394 +394 @@
      * @covers ::wp_enqueue_style
      */
-    function test_no_block_styles_for_viewing_without_theme_support() {
+    public function test_no_block_styles_for_viewing_without_theme_support() {
         // Confirm we are without theme support by default.
         $this->assertFalse( current_theme_supports( 'wp-block-styles' ) );
@@ -412 +412 @@
      * @covers ::wp_common_block_scripts_and_styles
      */
-    function test_block_styles_for_viewing_with_theme_support() {
+    public function test_block_styles_for_viewing_with_theme_support() {
         add_theme_support( 'wp-block-styles' );
 
@@ -429 +429 @@
      * @covers ::wp_default_styles
      */
-    function test_block_styles_for_viewing_without_split_styles() {
+    public function test_block_styles_for_viewing_without_split_styles() {
         add_filter( 'should_load_separate_core_block_assets', '__return_false' );
         wp_default_styles( $GLOBALS['wp_styles'] );
@@ -446 +446 @@
      * @covers ::wp_default_styles
      */
-    function test_block_styles_for_viewing_with_split_styles() {
+    public function test_block_styles_for_viewing_with_split_styles() {
         add_filter( 'should_load_separate_core_block_assets', '__return_true' );
         wp_default_styles( $GLOBALS['wp_styles'] );