Changeset 52010 for trunk/tests/phpunit/tests/feed/atom.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/feed/atom.php (modified) (4 diffs)

trunk/tests/phpunit/tests/feed/atom.php

@@ -67 +67 @@
      * This is a bit of a hack used to buffer feed content.
      */
-    function do_atom() {
+    private function do_atom() {
         ob_start();
         // Nasty hack! In the future it would better to leverage do_feed( 'atom' ).
@@ -86 +86 @@
      * with the expected child elements and attributes.
      */
-    function test_feed_element() {
+    public function test_feed_element() {
         $this->go_to( '/?feed=atom' );
         $feed = $this->do_atom();
@@ -130 +130 @@
      * Validate <entry> child elements.
      */
-    function test_entry_elements() {
+    public function test_entry_elements() {
         $this->go_to( '/?feed=atom' );
         $feed = $this->do_atom();
@@ -210 +210 @@
      * @ticket 33591
      */
-    function test_atom_enclosure_with_extended_url_length_type_parsing() {
+    public function test_atom_enclosure_with_extended_url_length_type_parsing() {
         $enclosures = array(
             array(