Changeset 52010 for trunk/tests/phpunit/tests/feed/rss2.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/feed/rss2.php (modified) (12 diffs)

trunk/tests/phpunit/tests/feed/rss2.php

@@ -79 +79 @@
          * This is a bit of a hack used to buffer feed content.
          */
-        function do_rss2() {
+        private function do_rss2() {
                 ob_start();
                 // Nasty hack! In the future it would better to leverage do_feed( 'rss2' ).
@@ -98 +98 @@
          * with the expected child elements and attributes.
          */
-        function test_rss_element() {
+        public function test_rss_element() {
                 $this->go_to( '/?feed=rss2' );
                 $feed = $this->do_rss2();
@@ -123 +123 @@
          * @return [type] [description]
          */
-        function test_channel_element() {
+        public function test_channel_element() {
                 $this->go_to( '/?feed=rss2' );
                 $feed = $this->do_rss2();
@@ -153 +153 @@
          * @ticket 39141
          */
-        function test_channel_pubdate_element_translated() {
+        public function test_channel_pubdate_element_translated() {
                 $original_locale = $GLOBALS['wp_locale'];
                 /* @var WP_Locale $locale */
@@ -176 +176 @@
         }
 
-        function test_item_elements() {
+        public function test_item_elements() {
                 $this->go_to( '/?feed=rss2' );
                 $feed = $this->do_rss2();
@@ -267 +267 @@
          * @ticket 9134
          */
-        function test_items_comments_closed() {
+        public function test_items_comments_closed() {
                 add_filter( 'comments_open', '__return_false' );
 
@@ -302 +302 @@
          * @ticket 30210
          */
-        function test_valid_home_feed_endpoint() {
+        public function test_valid_home_feed_endpoint() {
                 // An example of a valid home feed endpoint.
                 $this->go_to( 'feed/' );
@@ -330 +330 @@
          * @ticket 30210
          */
-        function test_valid_taxonomy_feed_endpoint() {
+        public function test_valid_taxonomy_feed_endpoint() {
                 // An example of an valid taxonomy feed endpoint.
                 $this->go_to( 'category/foo/feed/' );
@@ -358 +358 @@
          * @ticket 30210
          */
-        function test_valid_main_comment_feed_endpoint() {
+        public function test_valid_main_comment_feed_endpoint() {
                 // Generate a bunch of comments.
                 foreach ( self::$posts as $post ) {
@@ -391 +391 @@
          * @ticket 30210
          */
-        function test_valid_archive_feed_endpoint() {
+        public function test_valid_archive_feed_endpoint() {
                 // An example of an valid date archive feed endpoint.
                 $this->go_to( '2003/05/27/feed/' );
@@ -419 +419 @@
          * @ticket 30210
          */
-        function test_valid_single_post_comment_feed_endpoint() {
+        public function test_valid_single_post_comment_feed_endpoint() {
                 // An example of an valid date archive feed endpoint.
                 $this->go_to( get_post_comments_feed_link( self::$posts[0] ) );
@@ -447 +447 @@
          * @ticket 30210
          */
-        function test_valid_search_feed_endpoint() {
+        public function test_valid_search_feed_endpoint() {
                 // An example of an valid search feed endpoint.
                 $this->go_to( '?s=Lorem&feed=rss' );