Changeset 52010 for trunk/tests/phpunit/tests/file.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/file.php (modified) (16 diffs)

trunk/tests/phpunit/tests/file.php

@@ -6 +6 @@
 class Tests_File extends WP_UnitTestCase {
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -18 +18 @@
      * @group themes
      */
-    function test_get_file_data() {
+    public function test_get_file_data() {
         $theme_headers = array(
             'Name'        => 'Theme Name',
@@ -49 +49 @@
      * @group themes
      */
-    function test_get_file_data_with_cr_line_endings() {
+    public function test_get_file_data_with_cr_line_endings() {
         $headers = array(
             'SomeHeader'  => 'Some Header',
@@ -73 +73 @@
      * @group themes
      */
-    function test_get_file_data_with_php_open_tag_prefix() {
+    public function test_get_file_data_with_php_open_tag_prefix() {
         $headers = array(
             'TemplateName' => 'Template Name',
@@ -88 +88 @@
     }
 
-    function is_unique_writable_file( $path, $filename ) {
+    private function is_unique_writable_file( $path, $filename ) {
         $fullpath = $path . DIRECTORY_SEPARATOR . $filename;
 
@@ -111 +111 @@
     }
 
-    function test_unique_filename_is_valid() {
+    public function test_unique_filename_is_valid() {
         // Make sure it produces a valid, writable, unique filename.
         $filename = wp_unique_filename( $this->dir, __FUNCTION__ . '.txt' );
@@ -120 +120 @@
     }
 
-    function test_unique_filename_is_unique() {
+    public function test_unique_filename_is_unique() {
         // Make sure it produces two unique filenames.
         $name = __FUNCTION__;
@@ -136 +136 @@
     }
 
-    function test_unique_filename_is_sanitized() {
+    public function test_unique_filename_is_sanitized() {
         $name     = __FUNCTION__;
         $filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' );
@@ -148 +148 @@
     }
 
-    function test_unique_filename_with_slashes() {
+    public function test_unique_filename_with_slashes() {
         $name = __FUNCTION__;
         // "foo/foo.txt"
@@ -161 +161 @@
     }
 
-    function test_unique_filename_multiple_ext() {
+    public function test_unique_filename_multiple_ext() {
         $name     = __FUNCTION__;
         $filename = wp_unique_filename( $this->dir, $name . '.php.txt' );
@@ -173 +173 @@
     }
 
-    function test_unique_filename_no_ext() {
+    public function test_unique_filename_no_ext() {
         $name     = __FUNCTION__;
         $filename = wp_unique_filename( $this->dir, $name );
@@ -187 +187 @@
      * @dataProvider data_wp_tempnam_filenames
      */
-    function test_wp_tempnam( $case ) {
+    public function test_wp_tempnam( $case ) {
         $file = wp_tempnam( $case );
         unlink( $file );
@@ -193 +193 @@
         $this->assertNotEmpty( basename( basename( $file, '.tmp' ), '.zip' ) );
     }
-    function data_wp_tempnam_filenames() {
+    public function data_wp_tempnam_filenames() {
         return array(
             array( '0.zip' ),
@@ -207 +207 @@
      * @ticket 47186
      */
-    function test_file_signature_functions_as_expected() {
+    public function test_file_signature_functions_as_expected() {
         $file = wp_tempnam();
         file_put_contents( $file, 'WordPress' );
@@ -240 +240 @@
      * @ticket 47186
      */
-    function test_file_signature_expected_failure() {
+    public function test_file_signature_expected_failure() {
         $file = wp_tempnam();
         file_put_contents( $file, 'WordPress' );
@@ -257 +257 @@
     }
 
-    function filter_trust_plus85Tq_key( $keys ) {
+    public function filter_trust_plus85Tq_key( $keys ) {
         // A static once-off key used to verify verify_file_signature() works as expected.
         $keys[] = '+85TqMhxQVAYVW4BSCVkJQvZH4q7z8I9lePbvngvf7A=';