Changeset 52010 for trunk/tests/phpunit/tests/filesystem/base.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/filesystem/base.php (modified) (3 diffs)

trunk/tests/phpunit/tests/filesystem/base.php

@@ -5 +5 @@
  */
 abstract class WP_Filesystem_UnitTestCase extends WP_UnitTestCase {
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         add_filter( 'filesystem_method_file', array( $this, 'filter_abstraction_file' ) );
@@ -12 +12 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         global $wp_filesystem;
         remove_filter( 'filesystem_method_file', array( $this, 'filter_abstraction_file' ) );
@@ -21 +21 @@
     }
 
-    function filter_fs_method( $method ) {
+    public function filter_fs_method( $method ) {
         return 'MockFS';
     }
-    function filter_abstraction_file( $file ) {
+    public function filter_abstraction_file( $file ) {
         return dirname( dirname( __DIR__ ) ) . '/includes/mock-fs.php';
     }
 
-    function test_is_MockFS_sane() {
+    public function test_is_MockFS_sane() {
         global $wp_filesystem;
         $this->assertInstanceOf( 'WP_Filesystem_MockFS', $wp_filesystem );