Changeset 52010 for trunk/tests/phpunit/tests/filters.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/filters.php (modified) (15 diffs)

trunk/tests/phpunit/tests/filters.php

@@ -8 +8 @@
 class Tests_Filters extends WP_UnitTestCase {
 
-    function test_simple_filter() {
+    public function test_simple_filter() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -26 +26 @@
     }
 
-    function test_remove_filter() {
+    public function test_remove_filter() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -46 +46 @@
     }
 
-    function test_has_filter() {
+    public function test_has_filter() {
             $tag  = __FUNCTION__;
             $func = __FUNCTION__ . '_func';
@@ -61 +61 @@
 
     // One tag with multiple filters.
-    function test_multiple_filters() {
+    public function test_multiple_filters() {
         $a1  = new MockAction();
         $a2  = new MockAction();
@@ -78 +78 @@
     }
 
-    function test_filter_args_1() {
+    public function test_filter_args_1() {
         $a    = new MockAction();
         $tag  = __FUNCTION__;
@@ -93 +93 @@
     }
 
-    function test_filter_args_2() {
+    public function test_filter_args_2() {
         $a1   = new MockAction();
         $a2   = new MockAction();
@@ -118 +118 @@
     }
 
-    function test_filter_priority() {
+    public function test_filter_priority() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -149 +149 @@
     }
 
-    function test_all_filter() {
+    public function test_all_filter() {
         $a    = new MockAction();
         $tag1 = __FUNCTION__ . '_1';
@@ -173 +173 @@
     }
 
-    function test_remove_all_filter() {
+    public function test_remove_all_filter() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -200 +200 @@
      * @ticket 20920
      */
-    function test_remove_all_filters_should_respect_the_priority_argument() {
+    public function test_remove_all_filters_should_respect_the_priority_argument() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -219 +219 @@
      * @ticket 9886
      */
-    function test_filter_ref_array() {
+    public function test_filter_ref_array() {
         $obj = new stdClass();
         $a   = new MockAction();
@@ -238 +238 @@
      * @ticket 12723
      */
-    function test_filter_ref_array_result() {
+    public function test_filter_ref_array_result() {
         $obj = new stdClass();
         $a   = new MockAction();
@@ -265 +265 @@
     }
 
-    function _self_removal( $tag ) {
-        remove_action( $tag, array( $this, '_self_removal' ), 10, 1 );
-        return $tag;
-    }
-
     /**
      * @ticket 29070
      */
-    function test_has_filter_after_remove_all_filters() {
+    public function test_has_filter_after_remove_all_filters() {
         $a   = new MockAction();
         $tag = __FUNCTION__;
@@ -354 +349 @@
      */
     public function test_current_priority() {
-        add_action( 'test_current_priority', array( $this, '_current_priority_action' ), 99 );
+        add_action( 'test_current_priority', array( $this, 'current_priority_action' ), 99 );
         do_action( 'test_current_priority' );
-        remove_action( 'test_current_priority', array( $this, '_current_priority_action' ), 99 );
+        remove_action( 'test_current_priority', array( $this, 'current_priority_action' ), 99 );
 
         $this->assertSame( 99, $this->current_priority );
     }
 
-    public function _current_priority_action() {
+    public function current_priority_action() {
         global $wp_filter;
         $this->current_priority = $wp_filter[ current_filter() ]->current_priority();
@@ -370 +365 @@
      */
     public function test_other_priority() {
-        add_action( 'test_current_priority', array( $this, '_other_priority_action' ), 99 );
+        add_action( 'test_current_priority', array( $this, 'other_priority_action' ), 99 );
         do_action( 'test_current_priority' );
-        remove_action( 'test_current_priority', array( $this, '_other_priority_action' ), 99 );
+        remove_action( 'test_current_priority', array( $this, 'other_priority_action' ), 99 );
 
         $this->assertFalse( $this->current_priority );
     }
 
-    public function _other_priority_action() {
+    public function other_priority_action() {
         global $wp_filter;
         $this->current_priority = $wp_filter['the_content']->current_priority();