Changeset 52010 for trunk/tests/phpunit/tests/formatting/convertInvalidEntries.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/convertInvalidEntries.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/convertInvalidEntries.php

@@ -5 +5 @@
  */
 class Tests_Formatting_ConvertInvalidEntities extends WP_UnitTestCase {
-    function test_replaces_windows1252_entities_with_unicode_ones() {
+    public function test_replaces_windows1252_entities_with_unicode_ones() {
         $input  = '‚ƒ„…†‡ˆ‰Š‹Œ‘’“”•–—˜™š›œŸ';
         $output = '‚ƒ„…†‡ˆ‰Š‹Œ‘’“”•–—˜™š›œŸ';
@@ -14 +14 @@
      * @ticket 20503
      */
-    function test_replaces_latin_letter_z_with_caron() {
+    public function test_replaces_latin_letter_z_with_caron() {
         $input  = 'Žž';
         $output = 'Žž';
@@ -20 +20 @@
     }
 
-    function test_escapes_lone_ampersands() {
+    public function test_escapes_lone_ampersands() {
         $this->assertSame( 'at&t', convert_chars( 'at&t' ) );
     }