Changeset 52010 for trunk/tests/phpunit/tests/formatting/convertSmilies.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/convertSmilies.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/convertSmilies.php

@@ -49 +49 @@
          * when use_smilies = 1 and not when use_smilies = 0
          */
-        function test_convert_standard_smilies( $in_txt, $converted_txt ) {
+        public function test_convert_standard_smilies( $in_txt, $converted_txt ) {
                 // Standard smilies, use_smilies: ON.
                 update_option( 'use_smilies', 1 );
@@ -92 +92 @@
          * Validate Custom Smilies are converted to images when use_smilies = 1
          */
-        function test_convert_custom_smilies( $in_txt, $converted_txt ) {
+        public function test_convert_custom_smilies( $in_txt, $converted_txt ) {
                 global $wpsmiliestrans;
 
@@ -300 +300 @@
          * @dataProvider get_spaces_around_smilies
          */
-        function test_spaces_around_smilies( $in_txt, $converted_txt ) {
+        public function test_spaces_around_smilies( $in_txt, $converted_txt ) {
                 // Standard smilies, use_smilies: ON.
                 update_option( 'use_smilies', 1 );