Changeset 52010 for trunk/tests/phpunit/tests/formatting/ent2ncr.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/ent2ncr.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/ent2ncr.php

@@ -8 +8 @@
      * @dataProvider entities
      */
-    function test_converts_named_entities_to_numeric_character_references( $entity, $ncr ) {
+    public function test_converts_named_entities_to_numeric_character_references( $entity, $ncr ) {
         $entity = '&' . $entity . ';';
         $ncr    = '&#' . $ncr . ';';
@@ -18 +18 @@
      * Comments start with "###".
      */
-    function entities() {
+    public function entities() {
         $entities      = file( DIR_TESTDATA . '/formatting/entities.txt' );
         $data_provided = array();