Changeset 52010 for trunk/tests/phpunit/tests/formatting/escJs.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/escJs.php (modified) (4 diffs)

trunk/tests/phpunit/tests/formatting/escJs.php

@@ -5 +5 @@
  */
 class Tests_Formatting_EscJs extends WP_UnitTestCase {
-    function test_js_escape_simple() {
+    public function test_js_escape_simple() {
         $out = esc_js( 'foo bar baz();' );
         $this->assertSame( 'foo bar baz();', $out );
     }
 
-    function test_js_escape_quotes() {
+    public function test_js_escape_quotes() {
         $out = esc_js( 'foo "bar" \'baz\'' );
         // Does it make any sense to change " into "?  Why not \"?
@@ -16 +16 @@
     }
 
-    function test_js_escape_backslash() {
+    public function test_js_escape_backslash() {
         $bs  = '\\';
         $out = esc_js( 'foo ' . $bs . 't bar ' . $bs . $bs . ' baz' );
@@ -23 +23 @@
     }
 
-    function test_js_escape_amp() {
+    public function test_js_escape_amp() {
         $out = esc_js( 'foo & bar &baz;  ' );
         $this->assertSame( 'foo & bar &baz;  ', $out );
     }
 
-    function test_js_escape_quote_entity() {
+    public function test_js_escape_quote_entity() {
         $out = esc_js( 'foo ' bar ' baz &' );
         $this->assertSame( "foo \\' bar \\' baz &", $out );
     }
 
-    function test_js_no_carriage_return() {
+    public function test_js_no_carriage_return() {
         $out = esc_js( "foo\rbar\nbaz\r" );
         // \r is stripped.
@@ -39 +39 @@
     }
 
-    function test_js_escape_rn() {
+    public function test_js_escape_rn() {
         $out = esc_js( "foo\r\nbar\nbaz\r\n" );
         // \r is stripped.