Changeset 52010 for trunk/tests/phpunit/tests/formatting/escUrl.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/escUrl.php (modified) (17 diffs)

trunk/tests/phpunit/tests/formatting/escUrl.php

@@ -9 +9 @@
      * @ticket 23605
      */
-    function test_spaces() {
+    public function test_spaces() {
         $this->assertSame( 'http://example.com/Mr%20WordPress', esc_url( 'http://example.com/Mr WordPress' ) );
         $this->assertSame( 'http://example.com/Mr%20WordPress', esc_url( 'http://example.com/Mr%20WordPress' ) );
@@ -20 +20 @@
     }
 
-    function test_bad_characters() {
+    public function test_bad_characters() {
         $this->assertSame( 'http://example.com/watchthelinefeedgo', esc_url( 'http://example.com/watchthelinefeed%0Ago' ) );
         $this->assertSame( 'http://example.com/watchthelinefeedgo', esc_url( 'http://example.com/watchthelinefeed%0ago' ) );
@@ -34 +34 @@
     }
 
-    function test_relative() {
+    public function test_relative() {
         $this->assertSame( '/example.php', esc_url( '/example.php' ) );
         $this->assertSame( 'example.php', esc_url( 'example.php' ) );
@@ -41 +41 @@
     }
 
-    function test_all_url_parts() {
+    public function test_all_url_parts() {
         $url = 'https://user:pass@host.example.com:1234/path;p=1?query=2&r[]=3#fragment';
 
@@ -61 +61 @@
     }
 
-    function test_bare() {
+    public function test_bare() {
         $this->assertSame( 'http://example.com?foo', esc_url( 'example.com?foo' ) );
         $this->assertSame( 'http://example.com', esc_url( 'example.com' ) );
@@ -69 +69 @@
     }
 
-    function test_encoding() {
+    public function test_encoding() {
         $this->assertSame( 'http://example.com?foo=1&bar=2', esc_url_raw( 'http://example.com?foo=1&bar=2' ) );
         $this->assertSame( 'http://example.com?foo=1&bar=2', esc_url_raw( 'http://example.com?foo=1&bar=2' ) );
@@ -82 +82 @@
     }
 
-    function test_protocol() {
+    public function test_protocol() {
         $this->assertSame( 'http://example.com', esc_url( 'http://example.com' ) );
         $this->assertSame( '', esc_url( 'nasty://example.com/' ) );
@@ -147 +147 @@
      * @ticket 23187
      */
-    function test_protocol_case() {
+    public function test_protocol_case() {
         $this->assertSame( 'http://example.com', esc_url( 'HTTP://example.com' ) );
         $this->assertSame( 'http://example.com', esc_url( 'Http://example.com' ) );
     }
 
-    function test_display_extras() {
+    public function test_display_extras() {
         $this->assertSame( 'http://example.com/'quoted'', esc_url( 'http://example.com/\'quoted\'' ) );
         $this->assertSame( 'http://example.com/\'quoted\'', esc_url( 'http://example.com/\'quoted\'', null, 'notdisplay' ) );
     }
 
-    function test_non_ascii() {
+    public function test_non_ascii() {
         $this->assertSame( 'http://example.org/баба', esc_url( 'http://example.org/баба' ) );
         $this->assertSame( 'http://баба.org/баба', esc_url( 'http://баба.org/баба' ) );
@@ -163 +163 @@
     }
 
-    function test_feed() {
+    public function test_feed() {
         $this->assertSame( '', esc_url( 'feed:javascript:alert(1)' ) );
         $this->assertSame( '', esc_url( 'feed:javascript:feed:alert(1)' ) );
@@ -174 +174 @@
      * @ticket 16859
      */
-    function test_square_brackets() {
+    public function test_square_brackets() {
         $this->assertSame( '/example.php?one%5B%5D=two', esc_url( '/example.php?one[]=two' ) );
         $this->assertSame( '?foo%5Bbar%5D=baz', esc_url( '?foo[bar]=baz' ) );
@@ -189 +189 @@
      * Courtesy of http://blog.lunatech.com/2009/02/03/what-every-web-developer-must-know-about-url-encoding
      */
-    function test_reserved_characters() {
+    public function test_reserved_characters() {
         $url = "http://example.com/:@-._~!$&'()*+,=;:@-._~!$&'()*+,=:@-._~!$&'()*+,==?/?:@-._~!$%27()*+,;=/?:@-._~!$%27()*+,;==#/?:@-._~!$&'()*+,;=";
         $this->assertSame( $url, esc_url_raw( $url ) );
@@ -197 +197 @@
      * @ticket 21974
      */
-    function test_protocol_relative_with_colon() {
+    public function test_protocol_relative_with_colon() {
         $this->assertSame( '//example.com/foo?foo=abc:def', esc_url( '//example.com/foo?foo=abc:def' ) );
     }
@@ -204 +204 @@
      * @ticket 31632
      */
-    function test_mailto_with_newline() {
+    public function test_mailto_with_newline() {
         $body       = <<<EOT
 Hi there,
@@ -219 +219 @@
      * @ticket 31632
      */
-    function test_mailto_in_http_url_with_newline() {
+    public function test_mailto_in_http_url_with_newline() {
         $body       = <<<EOT
 Hi there,
@@ -234 +234 @@
      * @ticket 23605
      */
-    function test_mailto_with_spaces() {
+    public function test_mailto_with_spaces() {
         $body = 'Hi there, I thought you might want to sign up for this newsletter';
 
@@ -245 +245 @@
      * @ticket 28015
      */
-    function test_invalid_charaters() {
+    public function test_invalid_charaters() {
         $this->assertEmpty( esc_url_raw( '"^<>{}`' ) );
     }
@@ -252 +252 @@
      * @ticket 34202
      */
-    function test_ipv6_hosts() {
+    public function test_ipv6_hosts() {
         $this->assertSame( '//[::127.0.0.1]', esc_url( '//[::127.0.0.1]' ) );
         $this->assertSame( 'http://[::FFFF::127.0.0.1]', esc_url( 'http://[::FFFF::127.0.0.1]' ) );