Changeset 52010 for trunk/tests/phpunit/tests/formatting/humanTimeDiff.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/humanTimeDiff.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/humanTimeDiff.php

@@ -12 +12 @@
      * @dataProvider data_test_human_time_diff
      */
-    function test_human_time_diff( $expected, $stopdate, $message ) {
+    public function test_human_time_diff( $expected, $stopdate, $message ) {
         $startdate = new DateTime( '2016-01-01 12:00:00' );
         $this->assertSame( $expected, human_time_diff( $startdate->format( 'U' ), $stopdate->format( 'U' ) ), $message );
@@ -18 +18 @@
 
     // Data for test_human_time_diff.
-    function data_test_human_time_diff() {
+    public function data_test_human_time_diff() {
         return array(
             array(