Changeset 52010 for trunk/tests/phpunit/tests/formatting/makeClickable.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/makeClickable.php (modified) (18 diffs)

trunk/tests/phpunit/tests/formatting/makeClickable.php

@@ -5 +5 @@
  */
 class Tests_Formatting_MakeClickable extends WP_UnitTestCase {
-    function test_mailto_xss() {
+    public function test_mailto_xss() {
         $in = 'testzzz@"STYLE="behavior:url(\'#default#time2\')"onBegin="alert(\'refresh-XSS\')"';
         $this->assertSame( $in, make_clickable( $in ) );
     }
 
-    function test_valid_mailto() {
+    public function test_valid_mailto() {
         $valid_emails = array(
             'foo@example.com',
@@ -23 +23 @@
     }
 
-    function test_invalid_mailto() {
+    public function test_invalid_mailto() {
         $invalid_emails = array(
             'foo',
@@ -41 +41 @@
      * and (semi-)colons in URLs with protocol (i.e. http://wordpress.org).
      */
-    function test_strip_trailing_with_protocol() {
+    public function test_strip_trailing_with_protocol() {
         $urls_before   = array(
             'http://wordpress.org/hello.html',
@@ -68 +68 @@
      * and (semi-)colons in URLs with protocol (i.e. http://wordpress.org).
      */
-    function test_strip_trailing_with_protocol_nothing_afterwards() {
+    public function test_strip_trailing_with_protocol_nothing_afterwards() {
         $urls_before   = array(
             'http://wordpress.org/hello.html',
@@ -97 +97 @@
      * and (semi-)colons in URLs without protocol (i.e. www.wordpress.org).
      */
-    function test_strip_trailing_without_protocol() {
+    public function test_strip_trailing_without_protocol() {
         $urls_before   = array(
             'www.wordpress.org',
@@ -124 +124 @@
      * and (semi-)colons in URLs without protocol (i.e. www.wordpress.org).
      */
-    function test_strip_trailing_without_protocol_nothing_afterwards() {
+    public function test_strip_trailing_without_protocol_nothing_afterwards() {
         $urls_before   = array(
             'www.wordpress.org',
@@ -150 +150 @@
      * @ticket 4570
      */
-    function test_iri() {
+    public function test_iri() {
         $urls_before   = array(
             'http://www.詹姆斯.com/',
@@ -169 +169 @@
      * @ticket 10990
      */
-    function test_brackets_in_urls() {
+    public function test_brackets_in_urls() {
         $urls_before   = array(
             'http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software)',
@@ -208 +208 @@
      * @ticket 11211
      */
-    function test_real_world_examples() {
+    public function test_real_world_examples() {
         $urls_before   = array(
             'Example: WordPress, test (some text), I love example.com (http://example.org), it is brilliant',
@@ -229 +229 @@
      * @ticket 14993
      */
-    function test_twitter_hash_bang() {
+    public function test_twitter_hash_bang() {
         $urls_before   = array(
             'http://twitter.com/#!/wordpress/status/25907440233',
@@ -245 +245 @@
     }
 
-    function test_wrapped_in_angles() {
+    public function test_wrapped_in_angles() {
         $before   = array(
             'URL wrapped in angle brackets <http://example.com/>',
@@ -261 +261 @@
     }
 
-    function test_preceded_by_punctuation() {
+    public function test_preceded_by_punctuation() {
         $before   = array(
             'Comma then URL,http://example.com/',
@@ -283 +283 @@
     }
 
-    function test_dont_break_attributes() {
+    public function test_dont_break_attributes() {
         $urls_before   = array(
             "<img src='http://trunk.domain/wp-includes/images/smilies/icon_smile.gif' alt=':)' class='wp-smiley'>",
@@ -310 +310 @@
      * @ticket 23756
      */
-    function test_no_links_inside_pre_or_code() {
+    public function test_no_links_inside_pre_or_code() {
         $before = array(
             '<pre>http://wordpress.org</pre>',
@@ -351 +351 @@
      * @ticket 16892
      */
-    function test_click_inside_html() {
+    public function test_click_inside_html() {
         $urls_before   = array(
             '<span>http://example.com</span>',
@@ -365 +365 @@
     }
 
-    function test_no_links_within_links() {
+    public function test_no_links_within_links() {
         $in = array(
             'Some text with a link <a href="http://example.com">http://example.com</a>',
@@ -378 +378 @@
      * @ticket 16892
      */
-    function test_no_segfault() {
+    public function test_no_segfault() {
         $in  = str_repeat( 'http://example.com/2011/03/18/post-title/', 256 );
         $out = make_clickable( $in );
@@ -387 +387 @@
      * @ticket 19028
      */
-    function test_line_break_in_existing_clickable_link() {
+    public function test_line_break_in_existing_clickable_link() {
         $html = "<a
                   href='mailto:someone@example.com'>someone@example.com</a>";