Changeset 52010 for trunk/tests/phpunit/tests/formatting/redirect.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/redirect.php (modified) (8 diffs)

trunk/tests/phpunit/tests/formatting/redirect.php

@@ -7 +7 @@
  */
 class Tests_Formatting_Redirect extends WP_UnitTestCase {
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         add_filter( 'home_url', array( $this, 'home_url' ) );
     }
 
-    function home_url() {
+    public function home_url() {
         return 'http://example.com/';
     }
@@ -42 +42 @@
     }
 
-    function test_wp_sanitize_redirect() {
+    public function test_wp_sanitize_redirect() {
         $this->assertSame( 'http://example.com/watchthelinefeedgo', wp_sanitize_redirect( 'http://example.com/watchthelinefeed%0Ago' ) );
         $this->assertSame( 'http://example.com/watchthelinefeedgo', wp_sanitize_redirect( 'http://example.com/watchthelinefeed%0ago' ) );
@@ -61 +61 @@
      * @ticket 36998
      */
-    function test_wp_sanitize_redirect_should_encode_spaces() {
+    public function test_wp_sanitize_redirect_should_encode_spaces() {
         $this->assertSame( 'http://example.com/test%20spaces', wp_sanitize_redirect( 'http://example.com/test%20spaces' ) );
         $this->assertSame( 'http://example.com/test%20spaces%20in%20url', wp_sanitize_redirect( 'http://example.com/test spaces in url' ) );
@@ -69 +69 @@
      * @dataProvider valid_url_provider
      */
-    function test_wp_validate_redirect_valid_url( $url, $expected ) {
+    public function test_wp_validate_redirect_valid_url( $url, $expected ) {
         $this->assertSame( $expected, wp_validate_redirect( $url ) );
     }
@@ -76 +76 @@
      * @dataProvider invalid_url_provider
      */
-    function test_wp_validate_redirect_invalid_url( $url ) {
+    public function test_wp_validate_redirect_invalid_url( $url ) {
         $this->assertEquals( false, wp_validate_redirect( $url, false ) );
     }
 
-    function valid_url_provider() {
+    public function valid_url_provider() {
         return array(
             array( 'http://example.com', 'http://example.com' ),
@@ -96 +96 @@
     }
 
-    function invalid_url_provider() {
+    public function invalid_url_provider() {
         return array(
             // parse_url() fails.
@@ -168 +168 @@
      * @dataProvider relative_url_provider
      */
-    function test_wp_validate_redirect_relative_url( $current_uri, $url, $expected ) {
+    public function test_wp_validate_redirect_relative_url( $current_uri, $url, $expected ) {
         // Backup the global.
         $unset = false;
@@ -199 +199 @@
      * }
      */
-    function relative_url_provider() {
+    public function relative_url_provider() {
         return array(
             array(