Changeset 52010 for trunk/tests/phpunit/tests/formatting/removeAccents.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/removeAccents.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/removeAccents.php

@@ -81 +81 @@
     }
 
-    function _remove_accents_germanic_umlauts_cb() {
+    public function remove_accents_germanic_umlauts_cb() {
         return 'de_DE';
     }
@@ -89 +89 @@
      */
     public function test_remove_accents_germanic_umlauts() {
-        add_filter( 'locale', array( $this, '_remove_accents_germanic_umlauts_cb' ) );
+        add_filter( 'locale', array( $this, 'remove_accents_germanic_umlauts_cb' ) );
 
         $this->assertSame( 'AeOeUeaeoeuess', remove_accents( 'ÄÖÜäöüß' ) );
 
-        remove_filter( 'locale', array( $this, '_remove_accents_germanic_umlauts_cb' ) );
+        remove_filter( 'locale', array( $this, 'remove_accents_germanic_umlauts_cb' ) );
     }
 
-    public function _set_locale_to_danish() {
+    public function set_locale_to_danish() {
         return 'da_DK';
     }
@@ -104 +104 @@
      */
     public function test_remove_danish_accents() {
-        add_filter( 'locale', array( $this, '_set_locale_to_danish' ) );
+        add_filter( 'locale', array( $this, 'set_locale_to_danish' ) );
 
         $this->assertSame( 'AeOeAaaeoeaa', remove_accents( 'ÆØÅæøå' ) );
 
-        remove_filter( 'locale', array( $this, '_set_locale_to_danish' ) );
+        remove_filter( 'locale', array( $this, 'set_locale_to_danish' ) );
     }
 
-    public function _set_locale_to_catalan() {
+    public function set_locale_to_catalan() {
         return 'ca';
     }
@@ -119 +119 @@
      */
     public function test_remove_catalan_middot() {
-        add_filter( 'locale', array( $this, '_set_locale_to_catalan' ) );
+        add_filter( 'locale', array( $this, 'set_locale_to_catalan' ) );
 
         $this->assertSame( 'allallalla', remove_accents( 'al·lallaŀla' ) );
 
-        remove_filter( 'locale', array( $this, '_set_locale_to_catalan' ) );
+        remove_filter( 'locale', array( $this, 'set_locale_to_catalan' ) );
 
         $this->assertSame( 'al·lallalla', remove_accents( 'al·lallaŀla' ) );
     }
 
-    public function _set_locale_to_serbian() {
+    public function set_locale_to_serbian() {
         return 'sr_RS';
     }
@@ -136 +136 @@
      */
     public function test_transcribe_serbian_crossed_d() {
-        add_filter( 'locale', array( $this, '_set_locale_to_serbian' ) );
+        add_filter( 'locale', array( $this, 'set_locale_to_serbian' ) );
 
         $this->assertSame( 'DJdj', remove_accents( 'Đđ' ) );
 
-        remove_filter( 'locale', array( $this, '_set_locale_to_serbian' ) );
+        remove_filter( 'locale', array( $this, 'set_locale_to_serbian' ) );
 
         $this->assertSame( 'Dd', remove_accents( 'Đđ' ) );