Changeset 52010 for trunk/tests/phpunit/tests/formatting/sanitizeFileName.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/sanitizeFileName.php (modified) (8 diffs)

trunk/tests/phpunit/tests/formatting/sanitizeFileName.php

@@ -5 +5 @@
  */
 class Tests_Formatting_SanitizeFileName extends WP_UnitTestCase {
-        function test_munges_extensions() {
+        public function test_munges_extensions() {
                 // r17990
                 $file_name = sanitize_file_name( 'test.phtml.txt' );
@@ -11 +11 @@
         }
 
-        function test_removes_special_chars() {
+        public function test_removes_special_chars() {
                 $special_chars = array( '?', '[', ']', '/', '\\', '=', '<', '>', ':', ';', ',', "'", '"', '&', '$', '#', '*', '(', ')', '|', '~', '`', '!', '{', '}', '%', '+', '’', '«', '»', '”', '“', chr( 0 ) );
                 $string        = 'test';
@@ -24 +24 @@
          * @ticket 22363
          */
-        function test_removes_accents() {
+        public function test_removes_accents() {
                 $in  = 'àáâãäåæçèéêëìíîïñòóôõöøùúûüýÿ';
                 $out = 'aaaaaaaeceeeeiiiinoooooouuuuyy';
@@ -35 +35 @@
          * @ticket 16330
          */
-        function test_replaces_spaces() {
+        public function test_replaces_spaces() {
                 $urls = array(
                         'unencoded space.png'  => 'unencoded-space.png',
@@ -48 +48 @@
         }
 
-        function test_replaces_any_number_of_hyphens_with_one_hyphen() {
+        public function test_replaces_any_number_of_hyphens_with_one_hyphen() {
                 $this->assertSame( 'a-t-t', sanitize_file_name( 'a----t----t' ) );
         }
 
-        function test_trims_trailing_hyphens() {
+        public function test_trims_trailing_hyphens() {
                 $this->assertSame( 'a-t-t', sanitize_file_name( 'a----t----t----' ) );
         }
 
-        function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
+        public function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
                 $this->assertSame( 'a-t', sanitize_file_name( 'a          t' ) );
                 $this->assertSame( 'a-t', sanitize_file_name( "a    \n\n\nt" ) );
@@ -64 +64 @@
          * @ticket 16226
          */
-        function test_replaces_percent_sign() {
+        public function test_replaces_percent_sign() {
                 $this->assertSame( 'a22b.jpg', sanitize_file_name( 'a%22b.jpg' ) );
         }
 
-        function test_replaces_unnamed_file_extensions() {
+        public function test_replaces_unnamed_file_extensions() {
                 // Test filenames with both supported and unsupported extensions.
                 $this->assertSame( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
@@ -74 +74 @@
         }
 
-        function test_replaces_unnamed_file_extensionless() {
+        public function test_replaces_unnamed_file_extensionless() {
                 // Test a filenames that becomes extensionless.
                 $this->assertSame( 'no-extension', sanitize_file_name( '_.no-extension' ) );
@@ -82 +82 @@
          * @dataProvider data_wp_filenames
          */
-        function test_replaces_invalid_utf8_characters( $input, $expected ) {
+        public function test_replaces_invalid_utf8_characters( $input, $expected ) {
                 $this->assertSame( $expected, sanitize_file_name( $input ) );
         }
 
-        function data_wp_filenames() {
+        public function data_wp_filenames() {
                 return array(
                         array( urldecode( '%B1myfile.png' ), 'myfile.png' ),