Changeset 52010 for trunk/tests/phpunit/tests/formatting/sanitizeOrderby.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/sanitizeOrderby.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/sanitizeOrderby.php

@@ -10 +10 @@
      * @dataProvider valid_orderbys
      */
-    function test_valid( $orderby ) {
+    public function test_valid( $orderby ) {
         $this->assertSame( $orderby, sanitize_sql_orderby( $orderby ) );
     }
-    function valid_orderbys() {
+    public function valid_orderbys() {
         return array(
             array( '1' ),
@@ -37 +37 @@
      * @dataProvider invalid_orderbys
      */
-    function test_invalid( $orderby ) {
+    public function test_invalid( $orderby ) {
         $this->assertFalse( sanitize_sql_orderby( $orderby ) );
     }
-    function invalid_orderbys() {
+    public function invalid_orderbys() {
         return array(
             array( '' ),