Make WordPress Core


Ignore:
Timestamp:
11/04/2021 03:22:47 PM (3 years ago)
Author:
hellofromTonya
Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/formatting/sanitizeOrderby.php

    r51623 r52010  
    1010     * @dataProvider valid_orderbys
    1111     */
    12     function test_valid( $orderby ) {
     12    public function test_valid( $orderby ) {
    1313        $this->assertSame( $orderby, sanitize_sql_orderby( $orderby ) );
    1414    }
    15     function valid_orderbys() {
     15    public function valid_orderbys() {
    1616        return array(
    1717            array( '1' ),
     
    3737     * @dataProvider invalid_orderbys
    3838     */
    39     function test_invalid( $orderby ) {
     39    public function test_invalid( $orderby ) {
    4040        $this->assertFalse( sanitize_sql_orderby( $orderby ) );
    4141    }
    42     function invalid_orderbys() {
     42    public function invalid_orderbys() {
    4343        return array(
    4444            array( '' ),
Note: See TracChangeset for help on using the changeset viewer.