Changeset 52010 for trunk/tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php (modified) (10 diffs)

trunk/tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php

@@ -5 +5 @@
  */
 class Tests_Formatting_SanitizeTitleWithDashes extends WP_UnitTestCase {
-    function test_strips_html() {
+    public function test_strips_html() {
         $input    = 'Captain <strong>Awesome</strong>';
         $expected = 'captain-awesome';
@@ -11 +11 @@
     }
 
-    function test_strips_unencoded_percent_signs() {
+    public function test_strips_unencoded_percent_signs() {
         $this->assertSame( 'fran%c3%a7ois', sanitize_title_with_dashes( 'fran%c3%a7%ois' ) );
     }
 
-    function test_makes_title_lowercase() {
+    public function test_makes_title_lowercase() {
         $this->assertSame( 'abc', sanitize_title_with_dashes( 'ABC' ) );
     }
 
-    function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
+    public function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
         $this->assertSame( 'a-t', sanitize_title_with_dashes( 'a          t' ) );
         $this->assertSame( 'a-t', sanitize_title_with_dashes( "a    \n\n\nt" ) );
     }
 
-    function test_replaces_any_number_of_hyphens_with_one_hyphen() {
+    public function test_replaces_any_number_of_hyphens_with_one_hyphen() {
         $this->assertSame( 'a-t-t', sanitize_title_with_dashes( 'a----t----t' ) );
     }
 
-    function test_trims_trailing_hyphens() {
+    public function test_trims_trailing_hyphens() {
         $this->assertSame( 'a-t-t', sanitize_title_with_dashes( 'a----t----t----' ) );
     }
 
-    function test_handles_non_entity_ampersands() {
+    public function test_handles_non_entity_ampersands() {
         $this->assertSame( 'penn-teller-bull', sanitize_title_with_dashes( 'penn & teller bull' ) );
     }
@@ -60 +60 @@
     }
 
-    function test_replaces_nbsp() {
+    public function test_replaces_nbsp() {
         $this->assertSame( 'dont-break-the-space', sanitize_title_with_dashes( "don't break the space", '', 'save' ) );
     }
@@ -67 +67 @@
      * @ticket 31790
      */
-    function test_replaces_nbsp_entities() {
+    public function test_replaces_nbsp_entities() {
         $this->assertSame( 'dont-break-the-space', sanitize_title_with_dashes( "don't&nbsp;break&#160;the&nbsp;space", '', 'save' ) );
     }
 
-    function test_replaces_ndash_mdash() {
+    public function test_replaces_ndash_mdash() {
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do – the Dash', '', 'save' ) );
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do the — Dash', '', 'save' ) );
@@ -79 +79 @@
      * @ticket 31790
      */
-    function test_replaces_ndash_mdash_entities() {
+    public function test_replaces_ndash_mdash_entities() {
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do &ndash; the &#8211; Dash', '', 'save' ) );
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do &mdash; the &#8212; Dash', '', 'save' ) );
     }
 
-    function test_replaces_iexcel_iquest() {
+    public function test_replaces_iexcel_iquest() {
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( 'Just ¡a Slug', '', 'save' ) );
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( 'Just a Slug¿', '', 'save' ) );
     }
 
-    function test_replaces_angle_quotes() {
+    public function test_replaces_angle_quotes() {
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( '‹Just a Slug›', '', 'save' ) );
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( '«Just a Slug»', '', 'save' ) );
     }
 
-    function test_replaces_curly_quotes() {
+    public function test_replaces_curly_quotes() {
         $this->assertSame( 'hey-its-curly-joe', sanitize_title_with_dashes( 'Hey its “Curly Joe”', '', 'save' ) );
         $this->assertSame( 'hey-its-curly-joe', sanitize_title_with_dashes( 'Hey its ‘Curly Joe’', '', 'save' ) );
@@ -105 +105 @@
      * @ticket 49791
      */
-    function test_replaces_bullet() {
+    public function test_replaces_bullet() {
         $this->assertSame( 'fancy-title-amazing', sanitize_title_with_dashes( 'Fancy Title • Amazing', '', 'save' ) );
     }
 
-    function test_replaces_copy_reg_deg_trade() {
+    public function test_replaces_copy_reg_deg_trade() {
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( 'Just © a Slug', '', 'save' ) );
         $this->assertSame( 'just-a-slug', sanitize_title_with_dashes( '® Just a Slug', '', 'save' ) );
@@ -119 +119 @@
      * @ticket 10792
      */
-    function test_replaces_forward_slash() {
+    public function test_replaces_forward_slash() {
         $this->assertSame( 'songs-by-lennon-mccartney', sanitize_title_with_dashes( 'songs by Lennon/McCartney', '', 'save' ) );
         $this->assertSame( 'songs-by-lennon-mccartney', sanitize_title_with_dashes( 'songs by Lennon//McCartney', '', 'save' ) );
@@ -130 +130 @@
      * @ticket 19820
      */
-    function test_replaces_multiply_sign() {
+    public function test_replaces_multiply_sign() {
         $this->assertSame( '6x7-is-42', sanitize_title_with_dashes( '6×7 is 42', '', 'save' ) );
     }
@@ -137 +137 @@
      * @ticket 20772
      */
-    function test_replaces_standalone_diacritic() {
+    public function test_replaces_standalone_diacritic() {
         $this->assertSame( 'aaaa', sanitize_title_with_dashes( 'āáǎà', '', 'save' ) );
     }
@@ -144 +144 @@
      * @ticket 22395
      */
-    function test_replaces_acute_accents() {
+    public function test_replaces_acute_accents() {
         $this->assertSame( 'aaaa', sanitize_title_with_dashes( 'ááa´aˊ', '', 'save' ) );
     }