Changeset 52010 for trunk/tests/phpunit/tests/formatting/utf8UriEncode.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/utf8UriEncode.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/utf8UriEncode.php

@@ -12 +12 @@
      * @dataProvider data
      */
-    function test_percent_encodes_non_reserved_characters( $utf8, $urlencoded ) {
+    public function test_percent_encodes_non_reserved_characters( $utf8, $urlencoded ) {
         $this->assertSame( $urlencoded, utf8_uri_encode( $utf8 ) );
     }
@@ -19 +19 @@
      * @dataProvider data
      */
-    function test_output_is_not_longer_than_optional_length_argument( $utf8, $unused_for_this_test ) {
+    public function test_output_is_not_longer_than_optional_length_argument( $utf8, $unused_for_this_test ) {
         $max_length = 30;
         $this->assertTrue( strlen( utf8_uri_encode( $utf8, $max_length ) ) <= $max_length );
     }
 
-    function data() {
+    public function data() {
         $utf8_urls     = file( DIR_TESTDATA . '/formatting/utf-8/utf-8.txt' );
         $urlencoded    = file( DIR_TESTDATA . '/formatting/utf-8/urlencoded.txt' );