Changeset 52010 for trunk/tests/phpunit/tests/formatting/wpHtmlSplit.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/wpHtmlSplit.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/wpHtmlSplit.php

@@ -11 +11 @@
      * @dataProvider data_basic_features
      */
-    function test_basic_features( $input, $output ) {
+    public function test_basic_features( $input, $output ) {
         return $this->assertSame( $output, wp_html_split( $input ) );
     }
 
-    function data_basic_features() {
+    public function data_basic_features() {
         return array(
             array(
@@ -41 +41 @@
      * @dataProvider data_whole_posts
      */
-    function test_pcre_performance( $input ) {
+    public function test_pcre_performance( $input ) {
         $regex  = get_html_split_regex();
         $result = benchmark_pcre_backtracking( $regex, $input, 'split' );
@@ -47 +47 @@
     }
 
-    function data_whole_posts() {
+    public function data_whole_posts() {
         require_once DIR_TESTDATA . '/formatting/whole-posts.php';
         return data_whole_posts();