Changeset 52010 for trunk/tests/phpunit/tests/formatting/wpRicheditPre.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/wpRicheditPre.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/wpRicheditPre.php

@@ -7 +7 @@
 class Tests_Formatting_wpRicheditPre extends WP_UnitTestCase {
 
-    function _charset_iso_8859_1() {
+    public function charset_iso_8859_1() {
         return 'iso-8859-1';
     }
@@ -15 +15 @@
      * @ticket 23688
      */
-    function test_wp_richedit_pre_charset_iso_8859_1() {
-        add_filter( 'pre_option_blog_charset', array( $this, '_charset_iso_8859_1' ) );
+    public function test_wp_richedit_pre_charset_iso_8859_1() {
+        add_filter( 'pre_option_blog_charset', array( $this, 'charset_iso_8859_1' ) );
         $iso8859_1 = 'Fran' . chr( 135 ) . 'ais';
         $this->assertSame( '<p>' . $iso8859_1 . "</p>\n", wp_richedit_pre( $iso8859_1 ) );
-        remove_filter( 'pre_option_blog_charset', array( $this, '_charset_iso_8859_1' ) );
+        remove_filter( 'pre_option_blog_charset', array( $this, 'charset_iso_8859_1' ) );
     }
 
-    function _charset_utf_8() {
+    public function charset_utf_8() {
         return 'UTF-8';
     }
@@ -29 +29 @@
      * @ticket 23688
      */
-    function test_wp_richedit_pre_charset_utf_8() {
-        add_filter( 'pre_option_blog_charset', array( $this, '_charset_utf_8' ) );
+    public function test_wp_richedit_pre_charset_utf_8() {
+        add_filter( 'pre_option_blog_charset', array( $this, 'charset_utf_8' ) );
         $utf8 = 'Fran' . chr( 195 ) . chr( 167 ) . 'ais';
         $this->assertSame( '<p>' . $utf8 . "</p>\n", wp_richedit_pre( $utf8 ) );
-        remove_filter( 'pre_option_blog_charset', array( $this, '_charset_utf_8' ) );
+        remove_filter( 'pre_option_blog_charset', array( $this, 'charset_utf_8' ) );
     }
 }