Changeset 52010 for trunk/tests/phpunit/tests/formatting/wpSpecialchars.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/wpSpecialchars.php (modified) (6 diffs)

trunk/tests/phpunit/tests/formatting/wpSpecialchars.php

@@ -5 +5 @@
  */
 class Tests_Formatting_wpSpecialchars extends WP_UnitTestCase {
-    function test_wp_specialchars_basics() {
+    public function test_wp_specialchars_basics() {
         $html = '&<hello world>';
         $this->assertSame( $html, _wp_specialchars( $html ) );
@@ -13 +13 @@
     }
 
-    function test_allowed_entity_names() {
+    public function test_allowed_entity_names() {
         global $allowedentitynames;
 
@@ -27 +27 @@
     }
 
-    function test_not_allowed_entity_names() {
+    public function test_not_allowed_entity_names() {
         $ents = array( 'iacut', 'aposs', 'pos', 'apo', 'apo?', 'apo.*', '.*apo.*', 'apos ', ' apos', ' apos ' );
 
@@ -37 +37 @@
     }
 
-    function test_optionally_escapes_quotes() {
+    public function test_optionally_escapes_quotes() {
         $source = "\"'hello!'\"";
         $this->assertSame( '"'hello!'"', _wp_specialchars( $source, 'single' ) );
@@ -51 +51 @@
      * @dataProvider data_double_encoding
      */
-    function test_double_encoding( $input, $output ) {
+    public function test_double_encoding( $input, $output ) {
         return $this->assertSame( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, true ) );
     }
 
-    function data_double_encoding() {
+    public function data_double_encoding() {
         return array(
             array(
@@ -78 +78 @@
      * @dataProvider data_no_double_encoding
      */
-    function test_no_double_encoding( $input, $output ) {
+    public function test_no_double_encoding( $input, $output ) {
         return $this->assertSame( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, false ) );
     }
 
-    function data_no_double_encoding() {
+    public function data_no_double_encoding() {
         return array(
             array(