Changeset 52010 for trunk/tests/phpunit/tests/formatting/wpTrimWords.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/formatting/wpTrimWords.php (modified) (6 diffs)

trunk/tests/phpunit/tests/formatting/wpTrimWords.php

@@ -15 +15 @@
     private $long_text = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce varius lacinia vehicula. Etiam sapien risus, ultricies ac posuere eu, convallis sit amet augue. Pellentesque urna massa, lacinia vel iaculis eget, bibendum in mauris. Aenean eleifend pulvinar ligula, a convallis eros gravida non. Suspendisse potenti. Pellentesque et odio tortor. In vulputate pellentesque libero, sed dapibus velit mollis viverra. Pellentesque id urna euismod dolor cursus sagittis.';
 
-    function test_trims_to_55_by_default() {
+    public function test_trims_to_55_by_default() {
         $trimmed = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce varius lacinia vehicula. Etiam sapien risus, ultricies ac posuere eu, convallis sit amet augue. Pellentesque urna massa, lacinia vel iaculis eget, bibendum in mauris. Aenean eleifend pulvinar ligula, a convallis eros gravida non. Suspendisse potenti. Pellentesque et odio tortor. In vulputate pellentesque libero, sed dapibus velit…';
         $this->assertSame( $trimmed, wp_trim_words( $this->long_text ) );
     }
 
-    function test_trims_to_10() {
+    public function test_trims_to_10() {
         $trimmed = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce varius…';
         $this->assertSame( $trimmed, wp_trim_words( $this->long_text, 10 ) );
     }
 
-    function test_trims_to_5_and_uses_custom_more() {
+    public function test_trims_to_5_and_uses_custom_more() {
         $trimmed = 'Lorem ipsum dolor sit amet,[...] Read on!';
         $this->assertSame( $trimmed, wp_trim_words( $this->long_text, 5, '[...] Read on!' ) );
     }
 
-    function test_strips_tags_before_trimming() {
+    public function test_strips_tags_before_trimming() {
         $text    = 'This text contains a <a href="http://wordpress.org"> link </a> to WordPress.org!';
         $trimmed = 'This text contains a link&hellip;';
@@ -39 +39 @@
      * @ticket 18726
      */
-    function test_strips_script_and_style_content() {
+    public function test_strips_script_and_style_content() {
         $trimmed = 'This text contains. It should go.';
 
@@ -49 +49 @@
     }
 
-    function test_doesnt_trim_short_text() {
+    public function test_doesnt_trim_short_text() {
         $text = 'This is some short text.';
         $this->assertSame( $text, wp_trim_words( $text ) );
@@ -57 +57 @@
      * @ticket 44541
      */
-    function test_trims_to_20_counted_by_chars() {
+    public function test_trims_to_20_counted_by_chars() {
         switch_to_locale( 'ja_JP' );
         $expected = substr( $this->long_text, 0, 20 ) . '&hellip;';
@@ -68 +68 @@
      * @ticket 44541
      */
-    function test_trims_to_20_counted_by_chars_with_double_width_chars() {
+    public function test_trims_to_20_counted_by_chars_with_double_width_chars() {
         switch_to_locale( 'ja_JP' );
         $text     = str_repeat( 'あ', 100 );
@@ -80 +80 @@
      * @ticket 47867
      */
-    function test_works_with_non_numeric_num_words() {
+    public function test_works_with_non_numeric_num_words() {
         $this->assertSame( '', wp_trim_words( $this->long_text, '', '' ) );
         $this->assertSame( '', wp_trim_words( $this->long_text, 'abc', '' ) );