Changeset 52010 for trunk/tests/phpunit/tests/general/paginateLinks.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/general/paginateLinks.php (modified) (11 diffs)

trunk/tests/phpunit/tests/general/paginateLinks.php

@@ -10 +10 @@
     private $i18n_count = 0;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -16 +16 @@
     }
 
-    function test_defaults() {
+    public function test_defaults() {
         $page2  = get_pagenum_link( 2 );
         $page3  = get_pagenum_link( 3 );
@@ -34 +34 @@
     }
 
-    function test_format() {
+    public function test_format() {
         $page2  = home_url( '/page/2/' );
         $page3  = home_url( '/page/3/' );
@@ -57 +57 @@
     }
 
-    function test_prev_next_false() {
+    public function test_prev_next_false() {
         $home   = home_url( '/' );
         $page3  = get_pagenum_link( 3 );
@@ -82 +82 @@
     }
 
-    function test_prev_next_true() {
+    public function test_prev_next_true() {
         $home   = home_url( '/' );
         $page3  = get_pagenum_link( 3 );
@@ -109 +109 @@
     }
 
-    function increment_i18n_count() {
+    public function increment_i18n_count() {
         $this->i18n_count += 1;
     }
@@ -116 +116 @@
      * @ticket 25735
      */
-    function test_paginate_links_number_format() {
+    public function test_paginate_links_number_format() {
         $this->i18n_count = 0;
         add_filter( 'number_format_i18n', array( $this, 'increment_i18n_count' ) );
@@ -138 +138 @@
      * @ticket 24606
      */
-    function test_paginate_links_base_value() {
+    public function test_paginate_links_base_value() {
 
         // Current page: 2.
@@ -206 +206 @@
     }
 
-    function add_query_arg( $url ) {
+    public function add_query_arg( $url ) {
         return add_query_arg(
             array(
@@ -219 +219 @@
      * @ticket 29636
      */
-    function test_paginate_links_query_args() {
+    public function test_paginate_links_query_args() {
         add_filter( 'get_pagenum_link', array( $this, 'add_query_arg' ) );
         $links = paginate_links(
@@ -257 +257 @@
      * @ticket 30831
      */
-    function test_paginate_links_with_custom_query_args() {
+    public function test_paginate_links_with_custom_query_args() {
         add_filter( 'get_pagenum_link', array( $this, 'add_query_arg' ) );
         $links = paginate_links(