Changeset 52010 for trunk/tests/phpunit/tests/http/functions.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/http/functions.php (modified) (10 diffs)

trunk/tests/phpunit/tests/http/functions.php

@@ -10 +10 @@
      * @covers ::wp_remote_head
      */
-    function test_head_request() {
+    public function test_head_request() {
         // This URL gives a direct 200 response.
         $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
@@ -29 +29 @@
      * @covers ::wp_remote_head
      */
-    function test_head_redirect() {
+    public function test_head_redirect() {
         // This URL will 301 redirect.
         $url      = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
@@ -41 +41 @@
      * @covers ::wp_remote_head
      */
-    function test_head_404() {
+    public function test_head_404() {
         $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/awefasdfawef.jpg';
         $response = wp_remote_head( $url );
@@ -54 +54 @@
      * @covers ::wp_remote_retrieve_response_code
      */
-    function test_get_request() {
+    public function test_get_request() {
         $url = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
 
@@ -76 +76 @@
      * @covers ::wp_remote_retrieve_response_code
      */
-    function test_get_redirect() {
+    public function test_get_redirect() {
         // This will redirect to asdftestblog1.files.wordpress.com.
         $url = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
@@ -95 +95 @@
      * @covers ::wp_remote_get
      */
-    function test_get_redirect_limit_exceeded() {
+    public function test_get_redirect_limit_exceeded() {
         // This will redirect to asdftestblog1.files.wordpress.com.
         $url = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
@@ -114 +114 @@
      * @covers ::wp_remote_retrieve_cookie_value
      */
-    function test_get_response_cookies() {
+    public function test_get_response_cookies() {
         $url = 'https://login.wordpress.org/wp-login.php';
 
@@ -147 +147 @@
      * @covers ::wp_remote_retrieve_cookie
      */
-    function test_get_response_cookies_with_wp_http_cookie_object() {
+    public function test_get_response_cookies_with_wp_http_cookie_object() {
         $url = 'http://example.org';
 
@@ -183 +183 @@
      * @covers ::wp_remote_retrieve_cookie
      */
-    function test_get_response_cookies_with_name_value_array() {
+    public function test_get_response_cookies_with_name_value_array() {
         $url = 'http://example.org';
 
@@ -215 +215 @@
      * @covers WP_Http
      */
-    function test_get_cookie_host_only() {
+    public function test_get_cookie_host_only() {
         // Emulate WP_Http::request() internals.
         $requests_response = new Requests_Response();